Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc site menu reorganization #1500

Merged
merged 21 commits into from
Aug 29, 2024
Merged

Doc site menu reorganization #1500

merged 21 commits into from
Aug 29, 2024

Conversation

tinatownes
Copy link
Collaborator

@tinatownes tinatownes commented Jul 23, 2024

Summary:

Revises the order and hierarchy of left menu items, including

  • Combines active and inactive signal lists, prefixing inactive ones with "inactive" and listing them after all active signals.
  • Moves new endpoint tutorial and other dev tools into a dev tools section
  • Renames some pages to de-emphasize covidcast
  • Fixes some broken links.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@tinatownes tinatownes self-assigned this Jul 23, 2024
tinatownes and others added 2 commits July 23, 2024 13:43
Combine inactive quidel and active quidel. Rename "Other Endpoints".
Developer support section creation and organization.
@nmdefries nmdefries force-pushed the Tina_doc_page_reorganization branch from 162782e to a6d19fd Compare July 30, 2024 15:07
@tinatownes tinatownes requested a review from nmdefries August 27, 2024 16:09
@nmdefries nmdefries force-pushed the Tina_doc_page_reorganization branch from 1b01f09 to a91e883 Compare August 28, 2024 00:25
nmdefries
nmdefries previously approved these changes Aug 28, 2024
@nmdefries nmdefries changed the title Doc page reorganization Doc site menu reorganization Aug 28, 2024
nmdefries
nmdefries previously approved these changes Aug 28, 2024
Copy link

@nmdefries
Copy link
Contributor

@tinatownes can you build this locally and look at it again? I changed some names and formatting.

@nmdefries nmdefries self-requested a review August 29, 2024 16:19
@nmdefries nmdefries merged commit a36c1e3 into dev Aug 29, 2024
7 checks passed
@nmdefries nmdefries deleted the Tina_doc_page_reorganization branch August 29, 2024 16:20
@tinatownes
Copy link
Collaborator Author

@nmdefries, so sorry I'm late here! Looks good, minor questions:

  • On left menu, the second item "Main Endpoint (COVIDcast)" has its page titled "Main Epidata API". Should we change the page title to "Main Endpoint (COVIDcast)" as well?
  • Should I reorder the list of COVIDcast inactive signals so those are properly alphabetical, ie) move HHS higher, move DSEW lower, etc.? Same with moving Digital Surveillance Sensors under "Other Endpoints (COVID-19 and Other Diseases)" higher in the list?
  • The left menu item "COVID-19 Trends and Impact Survey (inactive)", should I change it to "inactive COVID-19 Trends and Impact Survey"?
  • If I should move forward with above edits, should I just make a new branch and submit a pull request?
    Thanks!

@tinatownes
Copy link
Collaborator Author

  1. no need to match
  2. nav ordering affecting alphabetizing, NAT opened another PR
  3. Nat already fixed, check your branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants