Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tau reco on MiniAOD: Update rules to circumvent I/O issue #120

Merged
merged 392 commits into from
Mar 26, 2019
Merged

Tau reco on MiniAOD: Update rules to circumvent I/O issue #120

merged 392 commits into from
Mar 26, 2019

Conversation

steggema
Copy link
Member

I found that the problem lies in edm::Ptrreco::PFCandidate not being retrievable within the rule. However, std::vector<edm::Ptrreco::PFCandidate > are properly restored, so the trick is to not directly restore the leading charged candidate (and same for leading and leading neutral candidate), but to take the first candidate in the collection of signal charged candidates, and so forth, making the same assumptions as in the regular current tau reconstruction (see RecoTauTag/RecoTau/src/RecoTauConstructor.cc).
Also updated base branch to CMSSW_10_6_0_pre2

forthommel and others added 30 commits February 25, 2019 10:06
…ithm, with an associated ESWatcher to only load it when changed
…rRulePrefireVetoBit-CMSSW_10_5_X

Revert "Create a prefire veto bit using trigger rules"
Removed unused functions in ClusteringTest
…acker

Made base and inheriting class agree on checkForCompatibility in CalibTracker
…0pre2

Migration to CMSSW_10_5_0_pre2 code base in ConfDB
Fix the modifier for HGCalRecHit.layerWeights
Fix clang warnings in CommonTools/CandAlgos
…sSolved

New working point for B parking skim
…uplication

Move duplicate getCtfTrackRef function to its own file
fixed bugs in relval_step.py and added VBF Hbb Hinv 2018 workflows
mrodozov and others added 25 commits March 11, 2019 15:35
…y are already in the reco and do not need to be run again. Only save them in the MicroEventContent
Phase2-hgx181 First step of making v10 HGCal geometry
…TriggerNtupleGen

Removed inclusion of Transform3DPJ from HGCalTriggerNtupleGen
…cs_106X

Introduce SiStripCalCosmics ALCARECO
…Analysis/ZMuMu

Remove warning in ElectroWeakAnalysis/ZMuMu
add import FWCore.ParameterSet.Config as cms to top to fix unit tests
…-defaultDataSetD35

Revert "Revert "Default data set for D35""
…/ClientConfig

Remove warning in DQMServices/ClientConfig
…ysis/MuonAssociators

Remove unused var in MuonAnalysis/MuonAssociators
…eTools/HcalOnlineDb

Fix comp error in CaloOnlineTools/HcalOnlineDb
…gger/TrackTrigger

Remove unused typedef in L1Trigger/TrackTrigger
…alCondDB

Remove copy pasted argument assingment
…Check-NotForDQM

bypassVersionCheck should not apply to DQMRootSource
…wPtGsfTracks_miniAOD_105X

Conversions from low pt gsf tracks mini aod 105x
@mbluj
Copy link

mbluj commented Mar 26, 2019

Hi Jan (@steggema),
thanks!
I have just made a visual inspection and find the changes fine. Unfortunately, I have not time for any other tests until (at least) mid April so I propose to go forward if Sebastian (@swozniewski) does not object.

@steggema
Copy link
Member Author

Thanks Michal. Given that @swozniewski may have limited connectivity this week, I'll go ahead with the merge sometime soon. In parallel, I'm working on resolving the conflicts you pointed out in the other thread.

@swozniewski
Copy link

Technically, my connectivity is ok but, in addition to the conference, an urgent issue with the fillDescription PR popped up, where Andrea and me are currently looking into. Unfortunately I'm not able to look into this at the moment. But please feel free to proceed with this if you feel confident about the changes.

@steggema steggema merged commit a5228c2 into cms-tau-pog:CMSSW_10_1_X_tau-pog_recoOnMiniAOD Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.