-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tau reco on MiniAOD: Update rules to circumvent I/O issue #120
Tau reco on MiniAOD: Update rules to circumvent I/O issue #120
Conversation
…ithm, with an associated ESWatcher to only load it when changed
…sSolved B parking Skimming code update
…rRulePrefireVetoBit-CMSSW_10_5_X Revert "Create a prefire veto bit using trigger rules"
…to the _cff files
Removed unused functions in ClusteringTest
…acker Made base and inheriting class agree on checkForCompatibility in CalibTracker
…0pre2 Migration to CMSSW_10_5_0_pre2 code base in ConfDB
Fix the modifier for HGCalRecHit.layerWeights
Fix clang warnings in CommonTools/CandAlgos
…sSolved New working point for B parking skim
…uplication Move duplicate getCtfTrackRef function to its own file
Fixed clang warnings in DQMOffline/RecoB
Removed HTMHTAnalyzer
fixed bugs in relval_step.py and added VBF Hbb Hinv 2018 workflows
…y are already in the reco and do not need to be run again. Only save them in the MicroEventContent
Phase2-hgx181 First step of making v10 HGCal geometry
Fix clang warnings in Calibration
…TriggerNtupleGen Removed inclusion of Transform3DPJ from HGCalTriggerNtupleGen
…cs_106X Introduce SiStripCalCosmics ALCARECO
…Analysis/ZMuMu Remove warning in ElectroWeakAnalysis/ZMuMu
add import FWCore.ParameterSet.Config as cms to top to fix unit tests
…-defaultDataSetD35 Revert "Revert "Default data set for D35""
…/ClientConfig Remove warning in DQMServices/ClientConfig
…ysis/MuonAssociators Remove unused var in MuonAnalysis/MuonAssociators
…eTools/HcalOnlineDb Fix comp error in CaloOnlineTools/HcalOnlineDb
…gger/TrackTrigger Remove unused typedef in L1Trigger/TrackTrigger
…alCondDB Remove copy pasted argument assingment
…Check-NotForDQM bypassVersionCheck should not apply to DQMRootSource
Fix CaloParticle Debugger
…wPtGsfTracks_miniAOD_105X Conversions from low pt gsf tracks mini aod 105x
HBHE: mahi speed up
…into test_pr22594
Hi Jan (@steggema), |
Thanks Michal. Given that @swozniewski may have limited connectivity this week, I'll go ahead with the merge sometime soon. In parallel, I'm working on resolving the conflicts you pointed out in the other thread. |
Technically, my connectivity is ok but, in addition to the conference, an urgent issue with the fillDescription PR popped up, where Andrea and me are currently looking into. Unfortunately I'm not able to look into this at the moment. But please feel free to proceed with this if you feel confident about the changes. |
I found that the problem lies in edm::Ptrreco::PFCandidate not being retrievable within the rule. However, std::vector<edm::Ptrreco::PFCandidate > are properly restored, so the trick is to not directly restore the leading charged candidate (and same for leading and leading neutral candidate), but to take the first candidate in the collection of signal charged candidates, and so forth, making the same assumptions as in the regular current tau reconstruction (see RecoTauTag/RecoTau/src/RecoTauConstructor.cc).
Also updated base branch to CMSSW_10_6_0_pre2