Fix the modifier for HGCalRecHit.layerWeights

[jingyucms]

Same as #25978

[cmsbuild]

The code-checks are being triggered in jenkins.

[jingyucms]

@kpedro88 Same as #25978 but for the master branch.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25979/8483

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @jingyucms (Jingyu Zhang) for master.

It involves the following packages:

RecoLocalCalo/HGCalRecProducers

@cmsbuild, @perrotta, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @sethzenz, @felicepantaleo, @rovere, @lgray, @cseez, @pfs, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

type bug-fix
this fixes a mistake from #25208

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33195/console Started: 2019/02/19 19:22

[cmsbuild]

+1
Tested at: 0b8ab3c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25979/33195/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25979/33195/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 1253 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3098286
• DQMHistoTests: Total failures: 53
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3098036
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[kpedro88]

changes appear in the D35 workflow with HGCal v9, as expected
@rovere FYI

[kpedro88]

+upgrade

[slava77]

+1

for #25979 0b8ab3c

• the configuration code changes are in line with the PR description; the bugfix appears clear and correct
• jenkins tests pass and comparisons with the baseline show differences only in the D35 phase-2 workflow as expected. Changes appear first in the HGCAL rec hit energies and from there in variables dependent on these downstream.
  e.g.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1