Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't declare undefined functions #9995

Merged
merged 1 commit into from
Jul 9, 2015
Merged

Don't declare undefined functions #9995

merged 1 commit into from
Jul 9, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jul 1, 2015

Undefined member functions were declared in class MET. This causes the ROOT dictionary in CMSSW_7_5_ROOT5_X to fail to compile. David Lange wanted me to remove or comment out the declarations in the mainstream ROOT6 release as well, so here it is.
Please expedite.

@wmtan wmtan mentioned this pull request Jul 1, 2015
Closed
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jul 1, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2015

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Don't declare undefined functions

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Jul 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2015

The tests are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

+1
Tested at: d02cc33
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9995/6086/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9995/6086/summary.html

davidlange6 added a commit that referenced this pull request Jul 9, 2015
@davidlange6
Merge pull request #9995 from wmtan/FixBuildErrorsInROOT5
1bbdfe0 
Don't declare undefined functions
@davidlange6 davidlange6 merged commit 1bbdfe0 into cms-sw:CMSSW_7_5_X Jul 9, 2015
@wmtan wmtan deleted the FixBuildErrorsInROOT5 branch July 9, 2015 21:04
@wmtan wmtan mentioned this pull request Jul 10, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.
5 participants
@wmtan @cmsbuild @monttj @Dr15Jones @davidlange6