Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back out ROOT6 specific change from ROOT 5 release #10139

Merged
merged 2 commits into from
Jul 13, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jul 10, 2015

This PR fixes the compilation errors in DPGAnalysis/SiStripTools in CMSSW_7_5_ROOT5_X.
It backs out a ROOT6 specific change, and corrects the name of a misspelled function.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_5_ROOT5_X.

Back out ROOT6 specific change from ROOT 5 rlease

It involves the following packages:

DPGAnalysis/SiStripTools

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 5215477
I found an error when building:

>> Leaving Package FWCore/Version
>> Package FWCore/Version built
>> Subsystem FWCore built
/afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc491/external/gcc/4.9.1-cms/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.9.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lDataFormatsLuminosity
/afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc491/external/gcc/4.9.1-cms/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.9.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lDataFormatsPatCandidates
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc491/src/DPGAnalysis/SiStripTools/src/DPGAnalysisSiStripTools/libDPGAnalysisSiStripTools.so] Error 1
Leaving library rule at DPGAnalysis/SiStripTools
>> Building shared library tmp/slc6_amd64_gcc491/src/DPGAnalysis/SiStripTools/bin/DPGAnalysisSiStripToolsMacros/libDPGAnalysisSiStripToolsMacros.so
>> Building capability library tmp/slc6_amd64_gcc491/src/DPGAnalysis/SiStripTools/src/DPGAnalysisSiStripTools/libDPGAnalysisSiStripToolsCapabilities.so
/afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc491/external/gcc/4.9.1-cms/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.9.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lDPGAnalysisSiStripTools


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10139/51/summary.html

@wmtan
Copy link
Contributor Author

wmtan commented Jul 10, 2015

@cmsbuild This build error is not caused by this PR, but is already in the base. The build errors in question were already fixed in CMSSW_7_5_ROOT5_X by the merging of PR #9995 from 7_5_X, which was already done but is not yet in an IB. Apparently, you are testing using the latest IB (CMSSW_7_5_ROOT5_X_2015-07-09-2300) and not the head of the branch. As the IB was built before #9995 was merged, you still get the errors fixed by #9995.

@wmtan wmtan changed the title Back out ROOT6 specific change from ROOT 5 rlease Back out ROOT6 specific change from ROOT 5 release Jul 10, 2015
davidlange6 added a commit that referenced this pull request Jul 13, 2015
Back out ROOT6 specific change from ROOT 5 release
@davidlange6 davidlange6 merged commit d3ca48a into cms-sw:CMSSW_7_5_ROOT5_X Jul 13, 2015
@wmtan wmtan deleted the FixBuildErrors branch July 14, 2015 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants