Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EITopPAG updates, merging with E/Gamma features #680

Conversation

rappoccio
Copy link
Contributor

Here is the full request for the changes to EITopPAG that were requested. This merges a few topics :

  1. Adding only b-tagging to the EITopPAG but nothing else (Adding b-tagging only to the EITopPAG #678)
  2. Adding the e/gamma changes to the GsfElectron (Porting changes for beaudett: was pullID 120 #156)
  3. Adding Volker's fixes to make it compatible (70 x fix for156 #666)

And finally this has a few additions of its own to bring everything together:

  1. In PFElectronTranslator, the isolation from pileup is actually filled. I also fixed a bug from topic branch 666. The python file was not in sync with the EDProducer for the names of the isolation variables.
  2. And of course, I changed EITopPAG top projection to use the updated variables.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rappoccio for CMSSW_7_0_X.

EITopPAG updates, merging with E/Gamma features

It involves the following packages:

Validation/RecoEgamma
RecoEgamma/EgammaElectronProducers
DataFormats/EgammaCandidates
CommonTools/ParticleFlow
RecoEgamma/EgammaElectronAlgos
RecoParticleFlow/PFProducer

@vadler, @thspeer, @rovere, @deguio, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@vadler
Copy link

vadler commented Sep 1, 2013

+1
All tests in CommonTools/ParticleFlow/test/ are broken. Nothing is run in IBs, but it should be fixed nevertheless.
However, that does not defeat the purpose of this feature branch.

@nclopezo
Copy link
Contributor

nclopezo commented Sep 3, 2013

Hi

I ran the tests on top of CMSSW_7_0_X_2013-09-02-0200, all tests passed

The logs are here:
https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/364/consoleFull

and the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/364/

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2013

The following categories have been signed by @deguio: DQM

@cms-git-dqm

@slava77
Copy link
Contributor

slava77 commented Sep 10, 2013

working on it @slava77

@slava77
Copy link
Contributor

slava77 commented Sep 11, 2013

+1

base release CMSSW_7_0_X_2013-09-10-0200
incremental reference CMSSW_7_0_X_2013-09-10-0200 + #666

Compared to base + #666, observe changes only in EI branches, consistent with the changes in pt and isolation cuts.
Comparison of #680 with the base shows an additional difference in the pfPhoton plots for conversions in the 19.0 workflow (gamma-35GeV), consistent with the change in the associator used in photonValidator_cfi.py

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

ktf added a commit that referenced this pull request Sep 11, 2013
…trecommendation_bugfixfromVolker

EITopPAG updates, merging with E/Gamma features
@ktf ktf merged commit 53a5a5c into cms-sw:CMSSW_7_0_X Sep 11, 2013
@rappoccio rappoccio deleted the rappoccio_merge_EITopPAG_latestrecommendation_bugfixfromVolker branch January 7, 2014 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants