Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating the EITopPAG changes to 700pre2 #548

Conversation

rappoccio
Copy link
Contributor

This is to fix the mangled tag here :

#346 (comment)

Please take this one for pull request.

The changes include :

  • Changes to the EITopPAG sequence to account for latest top PAG request :
    • Use delta-beta corrections in top projection for electrons
    • Add b-tagging.
    • This necessitates a dataformat change to GsfElectron to add the PU isolation that is computed in RECO

@ghost ghost assigned slava77 Aug 16, 2013
@ktf
Copy link
Contributor

ktf commented Aug 16, 2013

@slava77 @thspeer can you look into this?

PflowIsolationVariables()
: chargedHadronIso(0.), neutralHadronIso(0.), photonIso(0.)
: chargedHadronIso(0.), neutralHadronIso(0.), photonIso(0.), puIso(0.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in conflict with #156

@slava77
Copy link
Contributor

slava77 commented Aug 16, 2013

Changes in the electron /iso classes are in conflict with #156
I see that two features (b-tagging and isolation) are mixed up here
Sal, please take out the electron isolation part and work with Volker or/and Florian to get the rest in sync.
Better than mangling this single commit, may be easier to resubmit as a separate b-tag feature

@cmsbuild
Copy link
Contributor

The following categories have been rejected by @slava77: Reconstruction

@cms-git-reconstruction

@cmsbuild
Copy link
Contributor

The following categories have been rejected by @vadler: Analysis

@cms-git-analysis

@ktf
Copy link
Contributor

ktf commented Aug 21, 2013

Is this something to close or you plan to push again to this one?

@slava77
Copy link
Contributor

slava77 commented Aug 21, 2013

Hi Giulio,

I'd like to keep this open&rejected until the follow up appears.

The collision with #156 is still not resolved
and #156 which had a long history is apparently getting
somewhere deep with a ROOT io bug.

    --slava

On 8/21/13 4:07 PM, Giulio Eulisse wrote:

Is this something to close or you plan to push again to this one?


Reply to this email directly or view it on GitHub
#548 (comment).


Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: [email protected]
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)


@ktf
Copy link
Contributor

ktf commented Aug 21, 2013

Ok. Fine with me.

@rappoccio
Copy link
Contributor Author

I have added the b-tagging-only request here :

#678

@rappoccio
Copy link
Contributor Author

Updated here, closing this thread 👎

#680

@rappoccio rappoccio closed this Aug 30, 2013
@rappoccio rappoccio deleted the rappoccio_gsfElectronPUIsoFor700_15aug2013 branch August 30, 2013 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants