L1 P2GT region cut checks and fixing menu config

[artlbv]

PR description:

This is a follow up to #46489 addressing #47194

The issue appeared when the number of eta regions (bounds) did not match e.g. the number of pt region thresholds.

1. An exception has been introduced in the P2GT condition parser when the cut number does not match the number of eta regions as @HaarigerHarald suggested
2. Fixed menu conditions where the number of pt and eta regions did not match (should not affect trigger results)

PR validation:

In CMSSW_15_0_ASAN_X_2025-01-27-2300 workflow 29634.78 ran fine with the default L1P2GT:step1_2024 and the step1_2024_explicitSeeds menu.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47204/43475

[cmsbuild]

A new Pull Request was created by @artlbv for master.

It involves the following packages:

• L1Trigger/Configuration (l1)
• L1Trigger/Phase2L1GT (l1, upgrade)

@Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

type bug-fix

[mmusich]

test parameters:

• relvals_opt = --what upgrade
• workflows = 24834.0, 29634.0, 24834.911, 29634.78

[mmusich]

please test for CMSSW_15_0_ASAN_X

[artlbv]

thanks for launching the tests @mmusich , but the bot failed with "Unable to find CMSSW IB for CMSSW_15_0_ASAN_X."
@smuzaffar @iarspider do you know why this could fail?

[iarspider]

please test for CMSSW_15_0_ASAN_X/el8_amd64_gcc12

[iarspider]

thanks for launching the tests @mmusich , but the bot failed with "Unable to find CMSSW IB for CMSSW_15_0_ASAN_X." @smuzaffar @iarspider do you know why this could fail?

If IB type is built for multiple archtectures (e.g. ASAN is now built for el8_amd64_gcc12 and el8_amd64_gcc13), you need to explicitly specify the architecture.

[mmusich]

If IB type is built for multiple archtectures (e.g. ASAN is now built for el8_amd64_gcc12 and el8_amd64_gcc13), you need to explicitly specify the architecture.

looks like this was not a requirement in the past.

[cmsbuild]

Pull request #47204 was updated. @Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

[artlbv]

@smuzaffar @iarspider is it possible now to test with the ASAN build?
cms-sw/cms-bot#2425 seems merged

[aloeliger]

Please test

[smuzaffar]

please test for CMSSW_15_0_ASAN_X

@smuzaffar @iarspider is it possible now to test with the ASAN build? cms-sw/cms-bot#2425 seems merged

yes it is, I just requested the asan tests

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23fe54/44158/summary.html
COMMIT: 7e19b53
CMSSW: CMSSW_15_0_X_2025-02-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47204/44158/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 4233558
• DQMHistoTests: Total failures: 21
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4233517
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 228 log files, 197 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23fe54/44160/summary.html
COMMIT: 7e19b53
CMSSW: CMSSW_15_0_ASAN_X_2025-01-31-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47204/44160/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 145.301145.301_RunDisplacedJet2024E/step3_RunDisplacedJet2024E.log

[aloeliger]

The relval test is largely complaining about L1TMuonCPPFDigiProducer.

[mmusich]

The relval test is largely complaining about L1TMuonCPPFDigiProducer.

see #47204 (comment)

[mmusich]

is it possible now to test with the ASAN build?

I am not sure why testing with ASAN was requested again, given the analysis given already at #47204 (comment). To make the test fail again?

[mmusich]

urgent

[aloeliger]

+l1

This is fine from my side

[aloeliger]

@cms-sw/upgrade-l2 any comments?

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1