[Phase-2 L1] Incorporate object threshold scalings, ID and isolation via dictionaries into the P2GT menu

[artlbv]

PR description:

The idea of this PR is to allow for a more convenient organisation and book-keeping of the P2GT emulator menu configurations. Previously threshold changes due to object changes (so-called offline-online scalings) or ID/Iso WP changes had to be changed manually in every seed. With this PR dictionaries are introduced for common ID and Isolation Working Points as well as reading of the scalings (a MenuTools output) is implemented.

This addresses #46470 and was agreed to with the P2GT developer team @HaarigerHarald and @qvyz as presented here in slide 42.

FYI @VourMa @rovere @slaurila @RobertJWard @gpetruc

PR validation:

Tested to work with the standard recipe we (and HLT) are using in 1420pre1:

cmsDriver.py l1nanoPhase2 -s L1,L1TrackTrigger,L1P2GT,USER:PhysicsTools/L1Nano/l1tPh2Nano_cff.l1tPh2NanoTask --customise PhysicsTools/L1Nano/l1tPh2Nano_cff.addFullPh2L1Nano \                 
--conditions auto:phase2_realistic_T33 \
--geometry Extended2026D110 \
--era Phase2C17I13M9 \
--eventcontent NANOAOD \
--datatier GEN-SIM-DIGI-RAW-MINIAOD \
--customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000,Configuration/DataProcessing/Utils.addMonitoring,L1Trigger/Configuration/customisePhase2TTOn110.customisePhase2TTOn110 \
--filein /store/mc/Phase2Spring24DIGIRECOMiniAOD/TT_TuneCP5_14TeV-powheg-pythia8/GEN-SIM-DIGI-RAW-MINIAOD/PU200_AllTP_140X_mcRun4_realistic_v4-v1/2560000/11d1f6f0-5f03-421e-90c7-b5815197fc85.root \
--fileout file:output_Phase2_L1T.root \
--python_filename rerunL1_cfg.py \
--inputCommands="keep *, drop l1tPFJets_*_*_*, drop l1tTrackerMuons_l1tTkMuonsGmt*_*_HLT" \
--mc \
-n 1000 --nThreads 4

A simple check was comparing the edmConfigDump outputs pre and post PR as there the actual thresholds, ID and Isolation values are expanded into plaintext. The results seem reasonable.
Note that also the IDs used for TkMuons have changed since since the AR24 there are now 4 WPs (compared to 1 before).

We will check the agreement with the MenuTools once we get more stats processed (on small stats the agreement is rather good), but I would like to start the PR and the reviewing process, eventually soliciting feedback from our SW experts on these changes.

Note that the code function names in the menuConstants.py could be cleaned up etc, but the mechanism should the final one.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46489/42345

[cmsbuild]

A new Pull Request was created by @artlbv for master.

It involves the following packages:

• L1Trigger/Phase2L1GT (upgrade, l1)

@Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46489/42349

[cmsbuild]

Pull request #46489 was updated. @Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

[mmusich]

Does this incorporate the actual fix for

For example, pDoublePuppiTau52_52 in our measurements has ~3 times the rate of pSingleTkEle36

as discussed in #46470?

[mmusich]

enable hlt_p2_timing

[mmusich]

@cmsbuild, please test

[mmusich]

@cmsbuild, please abort

[mmusich]

please test

[artlbv]

Does this incorporate the actual fix for

For example, pDoublePuppiTau52_52 in our measurements has ~3 times the rate of pSingleTkEle36

as discussed in #46470?

Yes. At least the P2GT thresholds are now as in the MenuTools, and for the MenuTools we see similar rates to what we had in the AR24, see our recent presentation at the L1 DPG (linked above, slide 38). We will eventually also rerun the full MinBias but the good match of the MenuTools and P2GT emulator on 150 TTbar events makes me positive about a good agreement.

[cmsbuild]

Pull request #46489 was updated. @Moanwar, @aloeliger, @antoniovilela, @cmsbuild, @davidlange6, @epalencia, @fabiocos, @mandrenguyen, @rappoccio, @srimanob, @subirsarkar can you please check and sign again.

[artlbv]

@cmsbuild please test

[artlbv]

@aloeliger this PR is ready now. I fixed the spurious file and squashed the commits.
I launched the tests for formal checks, though the content is the same as tested before.

please review whenever you can!
thank you

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2424a/43933/summary.html
COMMIT: 41a716c
CMSSW: CMSSW_15_0_X_2025-01-23-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46489/43933/install.sh to create a dev area with all the needed externals and cmssw changes.

• HLT P2 Timing: chart

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 120 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3819085
• DQMHistoTests: Total failures: 103
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3818962
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: found differences in 4 / 47 workflows

[aloeliger]

+l1

[artlbv]

thanks Andrew!

@Moanwar could you please also review and sign this ?

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1