add fillDescriptions to several plugins used at HLT (3/N)

[mmusich]

PR description:

This PR is similar in spirit to #47017 and #47045. It adds fillDescriptions (and applies light modification to modernize the source code) to a bunch of plugins used at HLT for both Run 3 and Phase 2.

PR validation:

• addOnTests.py runs fine.
• hltPhase2UpgradeIntegrationTests runs fine.
• runTheMatrix.py --what upgrade -l 29634.0 --ibeos runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47079/43258

• There are other open Pull requests which might conflict with changes you have proposed:
  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Replace configuration-copying Alpaka ESProducers with MoveToDeviceCache #47047
  • File RecoLocalCalo/HcalRecProducers/src/HFPhase1Reconstructor.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoLocalCalo/HcalRecProducers/src/HFPreReconstructor.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoLocalTracker/SubCollectionProducers/src/SeedClusterRemoverPhase2.cc modified in PR(s): RecoLocalTracker/SubCollectionProducers: replacing existsAs with fillDescription for default parameter values #40610

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• EventFilter/SiStripRawToDigi (reconstruction)
• HLTrigger/Configuration (hlt)
• PhysicsTools/SelectorUtils (reconstruction)
• PhysicsTools/UtilAlgos (analysis)
• RecoLocalCalo/EcalRecProducers (reconstruction)
• RecoLocalCalo/HcalRecAlgos (reconstruction)
• RecoLocalCalo/HcalRecProducers (reconstruction)
• RecoLocalTracker/Phase2TrackerRecHits (reconstruction, upgrade)
• RecoLocalTracker/SiPhase2Clusterizer (reconstruction, upgrade)
• RecoLocalTracker/SiStripZeroSuppression (reconstruction)
• RecoLocalTracker/SubCollectionProducers (reconstruction)
• RecoTracker/FinalTrackSelectors (reconstruction)
• RecoTracker/SpecialSeedGenerators (reconstruction)

@Martin-Grunewald, @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich, @srimanob, @subirsarkar, @tvami can you please review it and eventually sign? Thanks.
@AnnikaStein, @GiacomoSguazzoni, @Martin-Grunewald, @ReyerBand, @SohamBhattacharya, @VinInn, @VourMa, @abdoulline, @alesaggio, @apsallid, @argiro, @bsunanda, @denizsun, @dgulhan, @echabert, @felicepantaleo, @gbenelli, @gpetruc, @jlidrych, @mariadalfonso, @missirol, @mmusich, @mtosi, @rchatter, @robervalwalsh, @rovere, @salimcerci, @thomreis, @threus, @wang0jin, @yduhm, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals-INPUT
Size: This PR adds an extra 224KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9675d6/43718/summary.html
COMMIT: ff84b8f
CMSSW: CMSSW_15_0_X_2025-01-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47079/43718/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestUtilAlgos had ERRORS

RelVals-INPUT

• 1002.31002.3_RunZeroBias2022B/step2_RunZeroBias2022B.log
• 1002.41002.4_RunDoubleMuon2022B/step2_RunDoubleMuon2022B.log

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 131 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3931861
• DQMHistoTests: Total failures: 2298
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3929543
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[Moanwar]

+Upgrade

[mmusich]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[Martin-Grunewald]

What do we do here in view of the imminent 150 pre?

[mmusich]

What do we do here in view of the imminent 150 pre?

Feel free to open a PR, otherwise I'll try to come back to this at latest tomorrow

[mmusich]

What do we do here in view of the imminent 150 pre?

see #47110