Remove all SealModules from the RecoMuon package

RecoMuon/CosmicMuonProducer/BuildFile.xml

@@ -26,4 +26,6 @@
 <use name="TrackingTools/TrackFitters"/>
 <use name="TrackingTools/TrajectoryState"/>
 <use name="TrackingTools/TransientTrackingRecHit"/>
-<flags EDM_PLUGIN="1"/>
+<export>
+  <lib name="1"/>
+</export>

RecoMuon/CosmicMuonProducer/plugins/BuildFile.xml

@@ -0,0 +1,13 @@
+<library file="*.cc" name="RecoMuonCosmicMuonProducerPlugins">
+  <use name="FWCore/Framework"/>
+  <use name="FWCore/ParameterSet"/>
+  <use name="FWCore/Utilities"/>
+  <use name="FWCore/MessageLogger"/>
+  <use name="DataFormats/MuonReco"/>
+  <use name="DataFormats/TrackReco"/>
+  <use name="DataFormats/TrajectorySeed"/>
+  <use name="RecoMuon/CosmicMuonProducer"/>
+  <use name="RecoMuon/TrackingTools"/>
+  <use name="TrackingTools/PatternTools"/>
+  <flags EDM_PLUGIN="1"/>
+</library>

RecoMuon/CosmicMuonProducer/src/CosmicMuonLinksProducer.cc → RecoMuon/CosmicMuonProducer/plugins/CosmicMuonLinksProducer.cc

@@ -1,4 +1,4 @@
-#include "RecoMuon/CosmicMuonProducer/src/CosmicMuonLinksProducer.h"
+#include "RecoMuon/CosmicMuonProducer/plugins/CosmicMuonLinksProducer.h"
 
 /**\class CosmicMuonLinksProducer
  *
@@ -152,3 +152,6 @@ int CosmicMuonLinksProducer::sharedHits(const reco::Track& track1, const reco::T
 
   return match;
 }
+
+#include "FWCore/Framework/interface/MakerMacros.h"
+DEFINE_FWK_MODULE(CosmicMuonLinksProducer);

RecoMuon/CosmicMuonProducer/src/CosmicMuonProducer.cc → RecoMuon/CosmicMuonProducer/plugins/CosmicMuonProducer.cc

@@ -1,4 +1,4 @@
-#include "RecoMuon/CosmicMuonProducer/src/CosmicMuonProducer.h"
+#include "RecoMuon/CosmicMuonProducer/plugins/CosmicMuonProducer.h"
 
 /**\class CosmicMuonProducer
  *
@@ -81,3 +81,6 @@ void CosmicMuonProducer::produce(Event& iEvent, const EventSetup& iSetup) {
   theService->update(iSetup);
   theTrackFinder->reconstruct(seeds, iEvent, iSetup);
 }
+
+#include "FWCore/Framework/interface/MakerMacros.h"
+DEFINE_FWK_MODULE(CosmicMuonProducer);

RecoMuon/CosmicMuonProducer/src/GlobalCosmicMuonProducer.cc → RecoMuon/CosmicMuonProducer/plugins/GlobalCosmicMuonProducer.cc

@@ -1,4 +1,4 @@
-#include "RecoMuon/CosmicMuonProducer/src/GlobalCosmicMuonProducer.h"
+#include "RecoMuon/CosmicMuonProducer/plugins/GlobalCosmicMuonProducer.h"
 
 /**\class GlobalCosmicMuonProducer
  *
@@ -91,3 +91,6 @@ void GlobalCosmicMuonProducer::produce(edm::Event& iEvent, const edm::EventSetup
   theTrackFinder->reconstruct(cosTrackCands, iEvent, iSetup);
   LogTrace(metname) << "Event loaded";
 }
+
+#include "FWCore/Framework/interface/MakerMacros.h"
+DEFINE_FWK_MODULE(GlobalCosmicMuonProducer);

RecoMuon/CosmicMuonProducer/test/CosmicMuonValidator.cc

@@ -797,3 +797,6 @@ TrajectoryStateOnSurface CosmicMuonValidator::updatedState(const TrajectoryState
 edm::ESHandle<Propagator> CosmicMuonValidator::propagator() const {
   return theService->propagator("SteppingHelixPropagatorAny");
 }
+
+#include "FWCore/Framework/interface/MakerMacros.h"
+DEFINE_FWK_MODULE(CosmicMuonValidator);

RecoMuon/CosmicMuonProducer/test/RealCosmicDataAnalyzer.cc

@@ -507,6 +507,5 @@ edm::ESHandle<Propagator> RealCosmicDataAnalyzer::propagator() const {
   return theService->propagator("SteppingHelixPropagatorAny");
 }
 
-//define this as a plug-in
-
+#include "FWCore/Framework/interface/MakerMacros.h"
 DEFINE_FWK_MODULE(RealCosmicDataAnalyzer);

RecoMuon/GlobalMuonProducer/BuildFile.xml → RecoMuon/GlobalMuonProducer/plugins/BuildFile.xml

@@ -1,12 +1,14 @@
-<use name="DataFormats/Common"/>
-<use name="DataFormats/MuonReco"/>
-<use name="DataFormats/TrackReco"/>
+<library file="*.cc" name="RecoMuonGlobalMuonProducerPlugins">
 <use name="FWCore/Framework"/>
 <use name="FWCore/MessageLogger"/>
 <use name="FWCore/ParameterSet"/>
 <use name="FWCore/PluginManager"/>
+<use name="DataFormats/Common"/>
+<use name="DataFormats/MuonReco"/>
+<use name="DataFormats/TrackReco"/>
 <use name="RecoMuon/GlobalTrackFinder"/>
 <use name="RecoMuon/GlobalTrackingTools"/>
 <use name="RecoMuon/TrackingTools"/>
 <use name="TrackingTools/PatternTools"/>
-<flags EDM_PLUGIN="1"/>
+  <flags EDM_PLUGIN="1"/>
+</library>

RecoMuon/GlobalMuonProducer/src/GlobalMuonProducer.cc → RecoMuon/GlobalMuonProducer/plugins/GlobalMuonProducer.cc

@@ -17,7 +17,7 @@
 #include "DataFormats/Common/interface/Handle.h"
 #include "FWCore/MessageLogger/interface/MessageLogger.h"
 
-#include "RecoMuon/GlobalMuonProducer/src/GlobalMuonProducer.h"
+#include "RecoMuon/GlobalMuonProducer/plugins/GlobalMuonProducer.h"
 
 // TrackFinder and specific GLB Trajectory Builder
 #include "RecoMuon/GlobalTrackFinder/interface/GlobalMuonTrajectoryBuilder.h"
@@ -151,3 +151,6 @@ void GlobalMuonProducer::produce(Event& event, const EventSetup& eventSetup) {
                     << "================================" << endl
                     << endl;
 }
+
+#include "FWCore/Framework/interface/MakerMacros.h"
+DEFINE_FWK_MODULE(GlobalMuonProducer);

RecoMuon/GlobalMuonProducer/src/TevMuonProducer.cc → RecoMuon/GlobalMuonProducer/plugins/TevMuonProducer.cc

@@ -16,7 +16,7 @@
 #include "FWCore/MessageLogger/interface/MessageLogger.h"
 #include "Geometry/Records/interface/TrackerTopologyRcd.h"
 
-#include "RecoMuon/GlobalMuonProducer/src/TevMuonProducer.h"
+#include "RecoMuon/GlobalMuonProducer/plugins/TevMuonProducer.h"
 
 // TrackFinder and specific GLB Trajectory Builder
 #include "RecoMuon/GlobalTrackFinder/interface/GlobalMuonTrajectoryBuilder.h"
@@ -145,3 +145,6 @@ void TevMuonProducer::produce(Event& event, const EventSetup& eventSetup) {
 
   LogTrace(metname) << "Done." << endl;
 }
+
+#include "FWCore/Framework/interface/MakerMacros.h"
+DEFINE_FWK_MODULE(TevMuonProducer);

RecoMuon/L2MuonIsolationProducer/BuildFile.xml → RecoMuon/L2MuonIsolationProducer/plugins/BuildFile.xml

@@ -1,3 +1,4 @@
+<library name="RecoMuonL2MuonIsolationProducerPlugins" file="*.cc">
 <use name="DataFormats/Common"/>
 <use name="DataFormats/RecoCandidate"/>
 <use name="DataFormats/TrackReco"/>
@@ -8,3 +9,4 @@
 <use name="PhysicsTools/IsolationAlgos"/>
 <use name="RecoMuon/MuonIsolation"/>
 <flags EDM_PLUGIN="1"/>
+</library>

RecoMuon/L2MuonIsolationProducer/src/L2MuonIsolationProducer.cc → RecoMuon/L2MuonIsolationProducer/plugins/L2MuonIsolationProducer.cc

@@ -12,7 +12,7 @@
 #include "FWCore/MessageLogger/interface/MessageLogger.h"
 
 #include "DataFormats/RecoCandidate/interface/IsoDepositDirection.h"
-#include "RecoMuon/L2MuonIsolationProducer/src/L2MuonIsolationProducer.h"
+#include "RecoMuon/L2MuonIsolationProducer/plugins/L2MuonIsolationProducer.h"
 
 #include "DataFormats/Common/interface/AssociationMap.h"
 #include "DataFormats/TrackReco/interface/Track.h"
@@ -186,3 +186,6 @@ void L2MuonIsolationProducer::produce(Event& event, const EventSetup& eventSetup
   LogDebug(metname) << " Event loaded"
                     << "================================";
 }
+
+#include "FWCore/Framework/interface/MakerMacros.h"
+DEFINE_FWK_MODULE(L2MuonIsolationProducer);

RecoMuon/L2MuonSeedGenerator/plugins/BuildFile.xml

@@ -16,5 +16,6 @@
     <use name="TrackingTools/TrajectoryParametrization"/>
     <use name="TrackingTools/TrajectoryState"/>
     <use name="clhep"/>
+    <use name="vdt"/>
     <flags EDM_PLUGIN="1"/>
 </library>

RecoMuon/L2MuonSeedGenerator/src/L2MuonSeedGenerator.cc → RecoMuon/L2MuonSeedGenerator/plugins/L2MuonSeedGenerator.cc

@@ -16,7 +16,7 @@
 //--------------------------------------------------
 
 // Class Header
-#include "RecoMuon/L2MuonSeedGenerator/src/L2MuonSeedGenerator.h"
+#include "RecoMuon/L2MuonSeedGenerator/plugins/L2MuonSeedGenerator.h"
 
 // Framework
 #include "FWCore/Framework/interface/ConsumesCollector.h"
@@ -402,3 +402,6 @@ const TrajectorySeed* L2MuonSeedGenerator::associateOfflineSeedToL1(edm::Handle<
 
   return selOffseed;
 }
+
+#include "FWCore/Framework/interface/MakerMacros.h"
+DEFINE_FWK_MODULE(L2MuonSeedGenerator);

RecoMuon/L2MuonSeedGenerator/src/L2MuonSeedGeneratorFromL1T.cc → RecoMuon/L2MuonSeedGenerator/plugins/L2MuonSeedGeneratorFromL1T.cc

@@ -18,7 +18,7 @@
 //--------------------------------------------------
 
 // Class Header
-#include "RecoMuon/L2MuonSeedGenerator/src/L2MuonSeedGeneratorFromL1T.h"
+#include "RecoMuon/L2MuonSeedGenerator/plugins/L2MuonSeedGeneratorFromL1T.h"
 
 // Framework
 #include "FWCore/Framework/interface/ConsumesCollector.h"
@@ -1047,3 +1047,6 @@ bool L2MuonSeedGeneratorFromL1T::isAssociateOfflineSeedToL1(
 
   return isAssociated;
 }
+
+#include "FWCore/Framework/interface/MakerMacros.h"
+DEFINE_FWK_MODULE(L2MuonSeedGeneratorFromL1T);

RecoMuon/L2MuonSeedGenerator/src/Phase2L2MuonSeedCreator.cc → RecoMuon/L2MuonSeedGenerator/plugins/Phase2L2MuonSeedCreator.cc

@@ -3,7 +3,7 @@
  *   \author Luca Ferragina (INFN BO), 2024
  */
 
-#include "RecoMuon/L2MuonSeedGenerator/src/Phase2L2MuonSeedCreator.h"
+#include "RecoMuon/L2MuonSeedGenerator/plugins/Phase2L2MuonSeedCreator.h"
 #include "RecoMuon/TransientTrackingRecHit/interface/MuonTransientTrackingRecHit.h"
 #include "RecoMuon/TrackingTools/interface/MuonPatternRecoDumper.h"
 
@@ -164,7 +164,7 @@ void Phase2L2MuonSeedCreator::produce(edm::Event& iEvent, const edm::EventSetup&
     unsigned int nCscHits = 0;
 
     // Loop on L1TkMu stubs to find best association to DT/CSC segments
-    for (auto stub : stubRefs) {
+    for (const auto& stub : stubRefs) {
 #ifdef EDM_ML_DEBUG
       stub->print();
 #endif
@@ -409,7 +409,7 @@ void Phase2L2MuonSeedCreator::produce(edm::Event& iEvent, const edm::EventSetup&
       // Find valid detectors with states
       auto detsWithStates = detLayer->compatibleDets(tsos, *service_->propagator(propagatorName_), *estimator_);
       // Check that at least one valid detector was found
-      if (detsWithStates.size() > 0) {
+      if (!detsWithStates.empty()) {
         // Update the detId with the one from the first valid detector with measurments found
         propagateToId = detsWithStates.front().first->geographicalId();
         // Create the Trajectory State on that detector's surface
@@ -486,7 +486,7 @@ const std::pair<int, int> Phase2L2MuonSeedCreator::matchingStubSegment(const DTC
   LogDebug(metname) << "Matching stub with DT segment";
   int nMatchingIds = 0;
 
-  for (DTChamberId id : matchingIds(stubId)) {
+  for (const DTChamberId& id : matchingIds(stubId)) {
     DTRecSegment4DCollection::range segmentsInChamber = segments.get(id);
     for (DTRecSegment4DCollection::const_iterator segment = segmentsInChamber.first;
          segment != segmentsInChamber.second;

RecoMuon/L3MuonIsolationProducer/BuildFile.xml

@@ -7,4 +7,6 @@
 <use name="FWCore/PluginManager"/>
 <use name="PhysicsTools/IsolationAlgos"/>
 <use name="RecoMuon/MuonIsolation"/>
-<flags EDM_PLUGIN="1"/>
+<export>
+  <lib name="1"/>
+</export>

RecoMuon/L3MuonIsolationProducer/plugins/BuildFile.xml

@@ -0,0 +1,13 @@
+<library name="RecoMuonL3MuonIsolationProducerPlugins" file="*.cc">
+    <use name="DataFormats/Common"/>
+    <use name="DataFormats/RecoCandidate"/>
+    <use name="DataFormats/TrackReco"/>
+    <use name="FWCore/Framework"/>
+    <use name="FWCore/MessageLogger"/>
+    <use name="FWCore/ParameterSet"/>
+    <use name="FWCore/PluginManager"/>
+    <use name="PhysicsTools/IsolationAlgos"/>
+    <use name="RecoMuon/MuonIsolation"/>
+    <use name="RecoMuon/L3MuonIsolationProducer"/>
+    <flags EDM_PLUGIN="1"/>
+</library>

RecoMuon/L3MuonIsolationProducer/src/L3MuonCombinedRelativeIsolationProducer.cc → RecoMuon/L3MuonIsolationProducer/plugins/L3MuonCombinedRelativeIsolationProducer.cc

@@ -1,4 +1,4 @@
-#include "L3MuonCombinedRelativeIsolationProducer.h"
+#include "RecoMuon/L3MuonIsolationProducer/plugins/L3MuonCombinedRelativeIsolationProducer.h"
 
 // Framework
 #include "FWCore/Framework/interface/Event.h"
@@ -25,7 +25,7 @@
 #include "PhysicsTools/IsolationAlgos/interface/IsoDepositExtractor.h"
 #include "PhysicsTools/IsolationAlgos/interface/IsoDepositExtractorFactory.h"
 
-#include "L3NominalEfficiencyConfigurator.h"
+#include "RecoMuon/L3MuonIsolationProducer/interface/L3NominalEfficiencyConfigurator.h"
 
 #include <string>
 
@@ -342,3 +342,6 @@ void L3MuonCombinedRelativeIsolationProducer::produce(Event& event, const EventS
     std::cout << " END OF EVENT "
               << "================================";
 }
+
+#include "FWCore/Framework/interface/MakerMacros.h"
+DEFINE_FWK_MODULE(L3MuonCombinedRelativeIsolationProducer);

RecoMuon/L3MuonIsolationProducer/src/L3MuonIsolationProducer.cc → RecoMuon/L3MuonIsolationProducer/plugins/L3MuonIsolationProducer.cc

@@ -1,4 +1,4 @@
-#include "L3MuonIsolationProducer.h"
+#include "RecoMuon/L3MuonIsolationProducer/plugins/L3MuonIsolationProducer.h"
 
 // Framework
 #include "FWCore/Framework/interface/Event.h"
@@ -23,7 +23,7 @@
 #include "PhysicsTools/IsolationAlgos/interface/IsoDepositExtractor.h"
 #include "PhysicsTools/IsolationAlgos/interface/IsoDepositExtractorFactory.h"
 
-#include "L3NominalEfficiencyConfigurator.h"
+#include "RecoMuon/L3MuonIsolationProducer/interface/L3NominalEfficiencyConfigurator.h"
 
 #include <string>
 
@@ -162,3 +162,6 @@ void L3MuonIsolationProducer::produce(Event& event, const EventSetup& eventSetup
   LogTrace(metname) << " END OF EVENT "
                     << "================================";
 }
+
+#include "FWCore/Framework/interface/MakerMacros.h"
+DEFINE_FWK_MODULE(L3MuonIsolationProducer);

RecoMuon/L3MuonIsolationProducer/src/L3MuonSumCaloPFIsolationProducer.cc → RecoMuon/L3MuonIsolationProducer/plugins/L3MuonSumCaloPFIsolationProducer.cc

@@ -1,4 +1,4 @@
-#include "L3MuonSumCaloPFIsolationProducer.h"
+#include "RecoMuon/L3MuonIsolationProducer/plugins/L3MuonSumCaloPFIsolationProducer.h"
 
 // Framework
 #include "FWCore/Framework/interface/Event.h"
@@ -76,3 +76,6 @@ void L3MuonSumCaloPFIsolationProducer::produce(edm::StreamID, edm::Event& iEvent
   isoFloatFiller.fill();
   iEvent.put(std::move(caloIsoMap));
 }
+
+#include "FWCore/Framework/interface/MakerMacros.h"
+DEFINE_FWK_MODULE(L3MuonSumCaloPFIsolationProducer);

RecoMuon/L3MuonIsolationProducer/src/L3NominalEfficiencyConfigurator.cc

@@ -1,4 +1,4 @@
-#include "L3NominalEfficiencyConfigurator.h"
+#include "RecoMuon/L3MuonIsolationProducer/interface/L3NominalEfficiencyConfigurator.h"
 #include "RecoMuon/MuonIsolation/interface/IsolatorByNominalEfficiency.h"
 
 using namespace muonisolation;