-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all SealModules
from the RecoMuon
package
#47065
Remove all SealModules
from the RecoMuon
package
#47065
Conversation
plugins directories Remove SealModule.cc
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47065/43232 |
A new Pull Request was created by @Parsifal-2045 for master. It involves the following packages:
@Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 476KB to repository Comparison SummarySummary:
|
+hlt
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
All modules in RecoMuon have been re-organized to follow the regular split in
interface
,src
andplugins
directories.interface
directoryplugins
directorysrc
directoryThese changes make the inclusion of all
SealModule.cc
files redundant, thus all the SealModules have been removed as per #47064 (comment).Technical, no regression expected.
PR validation:
Passes:
runTheMatrix.py -w upgrade -l 29834,29834.777,29834.778,29850,29850.777,29850.778
addOnTests.py