Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all SealModules from the RecoMuon package #47065

Merged
merged 10 commits into from
Jan 9, 2025

Conversation

Parsifal-2045
Copy link
Contributor

PR description:

All modules in RecoMuon have been re-organized to follow the regular split in interface, src and plugins directories.

  • Move header files to the interface directory
  • Move plugins to the plugins directory
  • Leave all supporting classes in the src directory

These changes make the inclusion of all SealModule.cc files redundant, thus all the SealModules have been removed as per #47064 (comment).

Technical, no regression expected.

PR validation:

Passes:

  • runTheMatrix.py -w upgrade -l 29834,29834.777,29834.778,29850,29850.777,29850.778
  • addOnTests.py

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

A new Pull Request was created by @Parsifal-2045 for master.

It involves the following packages:

  • RecoMuon/CosmicMuonProducer (reconstruction)
  • RecoMuon/GlobalMuonProducer (reconstruction)
  • RecoMuon/L2MuonIsolationProducer (reconstruction, hlt)
  • RecoMuon/L2MuonSeedGenerator (reconstruction, hlt)
  • RecoMuon/L3MuonIsolationProducer (reconstruction, hlt)
  • RecoMuon/L3MuonProducer (reconstruction, hlt)
  • RecoMuon/MuonSeedGenerator (reconstruction)
  • RecoMuon/StandAloneMuonProducer (reconstruction)
  • RecoMuon/TrackerSeedGenerator (reconstruction)
  • RecoMuon/TrackingTools (reconstruction)

@Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @HuguesBrun, @abbiendi, @andrea21z, @bellan, @cericeci, @jhgoh, @missirol, @mmusich, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jan 9, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

+1

Size: This PR adds an extra 476KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f75d03/43695/summary.html
COMMIT: 79465de
CMSSW: CMSSW_15_0_X_2025-01-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47065/43695/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3818730
  • DQMHistoTests: Total failures: 23
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3818687
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Jan 9, 2025

+hlt

  • technical, no regression expected, none seen.

@jfernan2
Copy link
Contributor

jfernan2 commented Jan 9, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d0b4b1d into cms-sw:master Jan 9, 2025
11 checks passed
@Parsifal-2045 Parsifal-2045 deleted the removeRecoMuonSealModules branch January 10, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants