Improved calculation of CRC32

[Dr15Jones]

PR description:

• made code a simple function
• switched to taking a std::string_view to avoid unnecessary allocations
• renamed function and file name to match

PR validation:

Unit tests pass.

[Dr15Jones]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46936/43008

• There are other open Pull requests which might conflict with changes you have proposed:
  • File EventFilter/L1TRawToDigi/src/AMCSpec.cc modified in PR(s): Improve L1TRawToDigi #46928

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• DataFormats/Provenance (core)
• EventFilter/L1TRawToDigi (l1)
• FWCore/Utilities (core)

@Dr15Jones, @aloeliger, @epalencia, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @felicepantaleo, @makortel, @missirol, @mmusich, @rovere, @thomreis, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c356ef/43442/summary.html
COMMIT: d8046a1
CMSSW: CMSSW_15_0_X_2024-12-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46936/43442/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 239 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3510017
• DQMHistoTests: Total failures: 4502
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3505495
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are related to #46416 and #39803

[makortel]

+core

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1