Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve L1TRawToDigi #46928

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve L1TRawToDigi #46928

wants to merge 2 commits into from

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • decrease number of allocations
  • use more efficient framework APIs
  • fixed memory leak in RegionalMuonGMTUnpacker

PR validation:

A slightly simpler version (without the use of std::span) was tested on PromptReco test job using CMSSW_14_0_9.

This includes the commit from #46918

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Dec 12, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46928/42994

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)
  • EventFilter/L1TRawToDigi (l1)
  • L1Trigger/L1TNtuples (l1)

@aloeliger, @antoniovagnerini, @epalencia, @rseidita can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 56KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11c2d3/43421/summary.html
COMMIT: 39f0f1f
CMSSW: CMSSW_15_0_X_2024-12-12-1700/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46928/43421/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@makortel makortel mentioned this pull request Dec 12, 2024
Open
@dinyar
Copy link
Contributor

dinyar commented Dec 13, 2024

Had a quick look, mostly at the GMT things (and there mostly at the small changes to the unpacker). lgtm.

dinyar
dinyar reviewed Dec 13, 2024
View reviewed changes
DQM/L1TMonitor/src/L1TMP7ZeroSupp.cc Outdated
// Want to have payload size in 32 bit words, but AMC measures
// it in 64 bit words -> factor 2.
const uint32_t* end = start + (amc.size() * 2);
const uint32_t* end = start + (payload64.size() * 2);

auto payload = std::make_unique<l1t::MP7Payload>(start, end, false);

// getBlock() returns a non-null unique_ptr on success
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm mistaken I think it would be good to update (or remove) this comment.

@Dr15Jones
Improve L1TRawToDigi
b38a7de 
- decrease number of allocations
- use more efficient framework APIs
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46928/43003

@cmsbuild
Copy link
Contributor

Pull request #46928 was updated. @aloeliger, @antoniovagnerini, @epalencia, @rseidita can you please check and sign again.

@cmsbuild cmsbuild mentioned this pull request Dec 13, 2024
Merged
@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 56KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11c2d3/43438/summary.html
COMMIT: b38a7de
CMSSW: CMSSW_15_0_X_2024-12-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46928/43438/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 2024.002001DAS Error
  • 2024.000001DAS Error
  • 2024.101001DAS Error
Expand to see more relval errors ...
  • 2024.200001
  • 2024.001001
  • 2024.202001
  • 2024.201001
  • 2024.100001

Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinyar dinyar dinyar left review comments

Assignees
No one assigned
Labels
code-checks-approved dqm-pending l1-pending orp-pending pending-signatures tests-rejected
Projects
None yet
Milestone
CMSSW_15_0_X
Development

Successfully merging this pull request may close these issues.
3 participants
@Dr15Jones @cmsbuild @dinyar