Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13_0_X Fixed FullModelHadronicProcess.cc energy deposit model #46845

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ctdax
Copy link
Contributor

@ctdax ctdax commented Dec 2, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of previous PR to CMSSW_13_0_X. This backport is necessary because CMSSW_13_0_X is a version that we expect to use for an upcoming analysis.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

A new Pull Request was created by @ctdax for CMSSW_13_0_X.

It involves the following packages:

  • SimG4Core/CustomPhysics (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @makortel, @martinamalberti, @rovere, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

cms-bot internal usage

@tvami
Copy link
Contributor

tvami commented Dec 2, 2024

backport of #46728

@tvami
Copy link
Contributor

tvami commented Dec 2, 2024

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d83a83/43198/summary.html
COMMIT: c4b1697
CMSSW: CMSSW_13_0_X_2024-12-01-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46845/43198/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283624
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283599
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Dec 3, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2defd84 into cms-sw:CMSSW_13_0_X Dec 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants