Fixed energy of R-Hadron cloud in energy deposit model

[ctdax]

PR description:

A 2015 commit to FullModelHadronicProcess.cc introduced a bug to the energy deposit model. This bug incorrectly deposited energy values close to the BSM particles mass into the simulated detector. This merge request reverts the energy deposit model to a previously working version from 2015. This is a work in progress, additional changes are expected to be made. Here are slides given to the EXO general group on the topic from November 19th, 2024

PR validation:

scram b runtests use-ibeos completed successfully.
runTheMatrix.py -l limited -i all --ibeos completed successfully without any failrues.
Below is a comparison of 10,000 identically seeded simulated energy deposits in the ECAL barrel with and without the bug.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46728/42698

[cmsbuild]

A new Pull Request was created by @ctdax for master.

It involves the following packages:

• SimG4Core/CustomPhysics (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @makortel, @martinamalberti, @rovere, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[civanch]

Let us test this PR

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91c699/42947/summary.html
COMMIT: 0ade249
CMSSW: CMSSW_14_2_X_2024-11-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46728/42947/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2024.0000012024.000001_RunZeroBias2024B_10k/step1_dasquery.log
• 2024.000001``````
• 2024.0030012024.003001_RunDisplacedJet2024B_10k/step1_dasquery.log

Expand to see more relval errors ...

• 2024.003001
• 2024.102001
• 2024.102001
• 2024.000001
• 2024.003001
• 2024.102001

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3344340
• DQMHistoTests: Total failures: 373
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3343947
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[civanch]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91c699/42980/summary.html
COMMIT: 0ade249
CMSSW: CMSSW_14_2_X_2024-11-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46728/42980/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3483722
• DQMHistoTests: Total failures: 455
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3483247
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[civanch]

@ctdax , I think that it is OK to merge this fix, further fixes/improvements may be in the next PRs. One thing I would recommend: please, substitute "Work in progress! Updated to" in the title by "Fixed energy of R-Hadron cloud in ". Edition of the title or description will no trigger new tests, precise title is usefull in the long term.

Depending on what Run period is considered for the analysis, backport(s) will be needed. If you foresee extra PRs on this subject, the backport may be the sum of all done for the master. If you are not sure, better to backport what is proposed in this PR now and do not postpond this.

[mandrenguyen]

+1

[mandrenguyen]

@ctdax , I think that it is OK to merge this fix, further fixes/improvements may be in the next PRs. One thing I would recommend: please, substitute "Work in progress! Updated to" in the title by "Fixed energy of R-Hadron cloud in ". Edition of the title or description will no trigger new tests, precise title is usefull in the long term.

I went ahead and took care of the title change. Please let me know if I did not follow the suggestion correctly.