-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BTV offline DQM sequences #46838
base: master
Are you sure you want to change the base?
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46838/42858
|
A new Pull Request was created by @mmarchegiani for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals RelVals-INPUT RelVals
RelVals-INPUT |
please test |
-1 Failed Tests: RelVals RelVals-INPUT RelVals
RelVals-INPUT |
PR description:
This PR updates the DQM sequences corresponding to the offline BTV DQM. Following the recent PR #46674 to include the DQM histograms of the newest Run-3 b-taggers, the
DQMOfflineBTag
sequence is redefined such that thebTagMiniDQMSource
producing the DQM histograms for the Run-3 taggers is executed. The harvesting step of the DQM is modified accordingly such that theDQMHarvestBTag
sequence is executed to fill the histograms.These changes are needed such that the alias
btag
defined in DQMOffline/Configuration/python/autoDQM.py, including the sequencesDQMOfflineBTag
andDQMHarvestBTag
, is running the production of the offline BTV DQM histograms.After this PR is merged, the tag
@btag
can be used in https://github.com/dmwm/T0/blob/master/etc/ProdOfflineConfiguration.py to run the BTV offline DQM on datasets at Tier-0.PR validation:
In order to test that the
@btag
tag is running the updated DQM sequences, the following command on theRun2024D/BTagMu
dataset is run to run the prompt reconstruction and DQM steps:Finally, the harvesting step is run with the following command:
The output file
DQM_V0001_R000380649__Global__CMSSW_X_Y_Z__RECO.root
is then opened with ROOT and explored with TBrowser to ensure that the BTV DQM histograms are correctly saved in the output.The generic tests described in https://cms-sw.github.io/PRWorkflow.html have been executed. All the tests run with
scram b runtests use-ibeos
are successful. Most of the tests run withrunTheMatrix.py -l limited -i all --ibeos
are successful, with some tests failed due toStep0-DAS_ERROR
:However, the
Step0-DAS_ERROR
is related to fetching the datasets and is not an error specific to our changes, therefore we open the PR.