Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BTV offline DQM sequences #46838

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mmarchegiani
Copy link

PR description:

This PR updates the DQM sequences corresponding to the offline BTV DQM. Following the recent PR #46674 to include the DQM histograms of the newest Run-3 b-taggers, the DQMOfflineBTag sequence is redefined such that the bTagMiniDQMSource producing the DQM histograms for the Run-3 taggers is executed. The harvesting step of the DQM is modified accordingly such that the DQMHarvestBTag sequence is executed to fill the histograms.
These changes are needed such that the alias btag defined in DQMOffline/Configuration/python/autoDQM.py, including the sequences DQMOfflineBTag and DQMHarvestBTag, is running the production of the offline BTV DQM histograms.
After this PR is merged, the tag @btag can be used in https://github.com/dmwm/T0/blob/master/etc/ProdOfflineConfiguration.py to run the BTV offline DQM on datasets at Tier-0.

PR validation:

In order to test that the @btag tag is running the updated DQM sequences, the following command on the Run2024D/BTagMu dataset is run to run the prompt reconstruction and DQM steps:

python3 $CMSSW_RELEASE_BASE/src/Configuration/DataProcessing/test/RunPromptReco.py --scenario=ppEra_Run3 --reco --aod --miniaod --global-tag 140X_dataRun3_Prompt_v2 --lfn=file:/eos/user/m/mmarcheg/BTVOfflineDQM/store/data/Run2024D/BTagMu/RAW/v1/000/380/649/00000/ff51f62b-a054-4b81-a6f3-58996b9044f6.root --alcarecos=TkAlMinBias+TkAlV0s --PhysicsSkims=LogError+LogErrorMonitor --dqmio --dqmSeq=@common+@btag

Finally, the harvesting step is run with the following command:

cmsDriver.py step4  -s HARVESTING:@btag --conditions auto:run3_data --data  --filetype DQM --scenario pp --era Run3_2024 -n 100 --filein file:output_inDQMIO.root --fileout file:step4.root

The output file DQM_V0001_R000380649__Global__CMSSW_X_Y_Z__RECO.root is then opened with ROOT and explored with TBrowser to ensure that the BTV DQM histograms are correctly saved in the output.

The generic tests described in https://cms-sw.github.io/PRWorkflow.html have been executed. All the tests run with scram b runtests use-ibeos are successful. Most of the tests run with runTheMatrix.py -l limited -i all --ibeos are successful, with some tests failed due to Step0-DAS_ERROR:

2022.000001_RunJetHT2022C_10k Step0-DAS_ERROR Step1-NOTRUN Step2-NOTRUN Step3-NOTRUN  - time date Thu Nov 28 19:38:13 2024-date Thu Nov 28 19:38:10 2024; exit: 256 0 0 0
2022.002001_RunZeroBias2022C_10k Step0-DAS_ERROR Step1-NOTRUN Step2-NOTRUN Step3-NOTRUN  - time date Thu Nov 28 19:38:16 2024-date Thu Nov 28 19:38:14 2024; exit: 256 0 0 0
2023.002001_RunZeroBias2023D_10k Step0-DAS_ERROR Step1-NOTRUN Step2-NOTRUN Step3-NOTRUN  - time date Thu Nov 28 19:38:18 2024-date Thu Nov 28 19:38:17 2024; exit: 256 0 0 0
2024.000001_RunZeroBias2024B_10k Step0-DAS_ERROR Step1-NOTRUN Step2-NOTRUN Step3-NOTRUN  - time date Thu Nov 28 19:38:21 2024-date Thu Nov 28 19:38:19 2024; exit: 256 0 0 0
2024.101001_RunBTagMu2024C_10k Step0-DAS_ERROR Step1-NOTRUN Step2-NOTRUN Step3-NOTRUN  - time date Thu Nov 28 19:38:23 2024-date Thu Nov 28 19:38:22 2024; exit: 256 0 0 0
2024.202001_RunJetMET02024D_10k Step0-DAS_ERROR Step1-NOTRUN Step2-NOTRUN Step3-NOTRUN  - time date Thu Nov 28 19:38:26 2024-date Thu Nov 28 19:38:24 2024; exit: 256 0 0 0
2024.303001_RunDisplacedJet2024E_10k Step0-DAS_ERROR Step1-NOTRUN Step2-NOTRUN Step3-NOTRUN  - time date Thu Nov 28 19:38:27 2024-date Thu Nov 28 19:38:26 2024; exit: 256 0 0 0

However, the Step0-DAS_ERROR is related to fetching the datasets and is not an error specific to our changes, therefore we open the PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46838/42858

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

A new Pull Request was created by @mmarchegiani for master.

It involves the following packages:

  • DQMOffline/Configuration (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@rociovilar, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@rseidita
Copy link
Contributor

rseidita commented Dec 2, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d376c/43183/summary.html
COMMIT: 7ab6ab4
CMSSW: CMSSW_15_0_X_2024-12-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46838/43183/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 02-Dec-2024 10:57:28 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 326479 lumi: 7 event: 1394020 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module MiniAODTaggerAnalyzer/'bTagDeepFlavourDQMBvsAllGlobalAnalyzer'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<pat::Jet>
Looking for module label: slimmedJetsPuppi
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
  • 140.61140.61_RunHI2022/step2_RunHI2022.log
  • 142.903142.903_RunUPC2016PA/step2_RunUPC2016PA.log
Expand to see more relval errors ...

@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d376c/43294/summary.html
COMMIT: 7ab6ab4
CMSSW: CMSSW_15_0_X_2024-12-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46838/43294/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 06-Dec-2024 11:02:44 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 326479 lumi: 7 event: 1394020 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module MiniAODTaggerAnalyzer/'bTagDeepFlavourDQMBvsAllGlobalAnalyzer'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<pat::Jet>
Looking for module label: slimmedJetsPuppi
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
  • 140.61140.61_RunHI2022/step2_RunHI2022.log
  • 142.903142.903_RunUPC2016PA/step2_RunUPC2016PA.log
Expand to see more relval errors ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants