[BTV,DQM] Expand MiniAOD input DQM and Validations plots with latest taggers, switch to slimmedJetsPuppi #46674

nurfikri89 · 2024-11-12T10:01:38Z

PR description:

This PR expands the BTV DQM & Validation plots by adding ParticleNet and UParT taggers that are stored in MiniAOD. The jet collection has changed to AK4 Puppi jets (slimmedJetsPuppi). The working point cut values updated to Summer23BPix campaign. Removed a few files and consolidated their contents into a single file.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos with the exception of a few workflows which failed because of missing relval input files.
passes MiniAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034

…rs produced during PAT step. Unify DQM and Validation.

cmsbuild · 2024-11-12T10:02:08Z

cms-bot internal usage

cmsbuild · 2024-11-12T10:04:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46674/42596

cmsbuild · 2024-11-12T10:04:25Z

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

DQMOffline/RecoB (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @rociovilar this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

antoniovagnerini · 2024-11-12T10:58:52Z

please test

cmsbuild · 2024-11-12T15:03:13Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42759/summary.html
COMMIT: 046c953
CMSSW: CMSSW_14_2_X_2024-11-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46674/42759/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

You potentially added 6 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3450336
DQMHistoTests: Total failures: 8582
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3441734
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 59281.600999999995 KiB( 46 files compared)
DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsEle_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsJet_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.620 KiB Btag/ParticleNetCentral_TauVsMu_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_BvsAll_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsEle_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsJet_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.612 KiB Btag/ParticleNetCentral_TauVsMu_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_BvsAll_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsB_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsL_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): ...
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: no differences found

nurfikri89 · 2024-11-13T20:54:56Z

Unit test fail due to this #46682?

antoniovagnerini · 2024-11-14T08:58:53Z

please test

antoniovagnerini · 2024-11-14T09:29:47Z

Unit test fail due to this #46682?

yes but it should be fixed now

cmsbuild · 2024-11-14T12:53:46Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42834/summary.html
COMMIT: 046c953
CMSSW: CMSSW_14_2_X_2024-11-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46674/42834/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS
---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 284 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3450524
DQMHistoTests: Total failures: 10440
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3440064
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 59281.600999999995 KiB( 46 files compared)
DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsEle_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsJet_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.620 KiB Btag/ParticleNetCentral_TauVsMu_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_BvsAll_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsEle_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsJet_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.612 KiB Btag/ParticleNetCentral_TauVsMu_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_BvsAll_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsB_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsL_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): ...
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: no differences found

smuzaffar · 2024-11-14T13:02:57Z

please test

cmsbuild · 2024-11-14T16:28:57Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42850/summary.html
COMMIT: 046c953
CMSSW: CMSSW_14_2_X_2024-11-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46674/42850/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3450524
DQMHistoTests: Total failures: 8538
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3441966
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 59281.600999999995 KiB( 46 files compared)
DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsEle_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsJet_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.620 KiB Btag/ParticleNetCentral_TauVsMu_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_BvsAll_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsEle_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsJet_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.612 KiB Btag/ParticleNetCentral_TauVsMu_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_BvsAll_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsB_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsL_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): ...
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: no differences found

antoniovagnerini · 2024-11-18T09:21:50Z

please test

cmsbuild · 2024-11-18T12:59:57Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42920/summary.html
COMMIT: 046c953
CMSSW: CMSSW_14_2_X_2024-11-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46674/42920/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

You potentially removed 4 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3451109
DQMHistoTests: Total failures: 8635
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3442454
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 59281.600999999995 KiB( 46 files compared)
DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsEle_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsJet_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.620 KiB Btag/ParticleNetCentral_TauVsMu_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_BvsAll_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsEle_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsJet_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.612 KiB Btag/ParticleNetCentral_TauVsMu_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_BvsAll_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsB_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsL_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): ...
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: no differences found

antoniovagnerini · 2024-11-18T14:54:25Z

please test

cmsbuild · 2024-11-18T18:20:00Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42935/summary.html
COMMIT: 046c953
CMSSW: CMSSW_14_2_X_2024-11-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46674/42935/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 6 lines to the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3451109
DQMHistoTests: Total failures: 8578
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3442511
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 59281.600999999995 KiB( 46 files compared)
DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsEle_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsJet_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.620 KiB Btag/ParticleNetCentral_TauVsMu_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_BvsAll_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsEle_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsJet_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.612 KiB Btag/ParticleNetCentral_TauVsMu_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_BvsAll_ETA_0-1v4
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsB_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsL_ETA_1v4-2v5
DQMHistoSizes: changed ( 1000.0 ): ...
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: no differences found

antoniovagnerini · 2024-11-19T13:57:00Z

+1

spurious differences from HGCal DQM test (open issue Non reproducibility in HGCal DQM #46416)

cmsbuild · 2024-11-19T13:57:27Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-11-19T21:17:59Z

+1

nurfikri89 added 5 commits October 30, 2024 21:16

Put all taggers and selections in single files

6463571

Switch to slimmedJetsPuppi. Schedule to make histograms for all tagge…

6bd8901

…rs produced during PAT step. Unify DQM and Validation.

Delete old tagger files. They are now in bTagMiniDQMTaggers.py

82153f3

Consolidate all tag analysis block into cff file

e594a49

Update WP cut values for DeepJet and ParticleNet. Use Summer23BPix.

046c953

cmsbuild added this to the CMSSW_14_2_X milestone Nov 12, 2024

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Nov 12, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 12, 2024

cmsbuild added tests-started and removed tests-pending labels Nov 12, 2024

cmsbuild added tests-rejected and removed tests-started labels Nov 12, 2024

cmsbuild added tests-started and removed tests-rejected labels Nov 14, 2024

cmsbuild removed the tests-started label Nov 14, 2024

cmsbuild added the tests-rejected label Nov 14, 2024

cmsbuild added tests-started and removed tests-rejected labels Nov 14, 2024

cmsbuild added tests-rejected and removed tests-started labels Nov 14, 2024

cmsbuild added tests-started and removed tests-rejected labels Nov 18, 2024

cmsbuild added tests-rejected and removed tests-started labels Nov 18, 2024

cmsbuild added tests-started and removed tests-rejected labels Nov 18, 2024

cmsbuild added tests-approved and removed tests-started labels Nov 18, 2024

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Nov 19, 2024

cmsbuild added orp-approved and removed orp-pending labels Nov 19, 2024

cmsbuild merged commit 1b383b0 into cms-sw:master Nov 19, 2024
11 checks passed

mmarchegiani mentioned this pull request Dec 2, 2024

Update BTV offline DQM sequences #46838

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BTV,DQM] Expand MiniAOD input DQM and Validations plots with latest taggers, switch to slimmedJetsPuppi #46674

[BTV,DQM] Expand MiniAOD input DQM and Validations plots with latest taggers, switch to slimmedJetsPuppi #46674

nurfikri89 commented Nov 12, 2024

cmsbuild commented Nov 12, 2024 •

edited

Loading

cmsbuild commented Nov 12, 2024

cmsbuild commented Nov 12, 2024

antoniovagnerini commented Nov 12, 2024

cmsbuild commented Nov 12, 2024

nurfikri89 commented Nov 13, 2024

antoniovagnerini commented Nov 14, 2024

antoniovagnerini commented Nov 14, 2024

cmsbuild commented Nov 14, 2024

smuzaffar commented Nov 14, 2024

cmsbuild commented Nov 14, 2024

antoniovagnerini commented Nov 18, 2024

cmsbuild commented Nov 18, 2024

antoniovagnerini commented Nov 18, 2024

cmsbuild commented Nov 18, 2024

antoniovagnerini commented Nov 19, 2024

cmsbuild commented Nov 19, 2024

mandrenguyen commented Nov 19, 2024

[BTV,DQM] Expand MiniAOD input DQM and Validations plots with latest taggers, switch to slimmedJetsPuppi #46674

[BTV,DQM] Expand MiniAOD input DQM and Validations plots with latest taggers, switch to slimmedJetsPuppi #46674

Conversation

nurfikri89 commented Nov 12, 2024

PR description:

PR validation:

cmsbuild commented Nov 12, 2024 • edited Loading

cmsbuild commented Nov 12, 2024

cmsbuild commented Nov 12, 2024

antoniovagnerini commented Nov 12, 2024

cmsbuild commented Nov 12, 2024

Unit Tests

Comparison Summary

nurfikri89 commented Nov 13, 2024

antoniovagnerini commented Nov 14, 2024

antoniovagnerini commented Nov 14, 2024

cmsbuild commented Nov 14, 2024

Unit Tests

Comparison Summary

smuzaffar commented Nov 14, 2024

cmsbuild commented Nov 14, 2024

Unit Tests

Comparison Summary

antoniovagnerini commented Nov 18, 2024

cmsbuild commented Nov 18, 2024

Unit Tests

Comparison Summary

antoniovagnerini commented Nov 18, 2024

cmsbuild commented Nov 18, 2024

Comparison Summary

antoniovagnerini commented Nov 19, 2024

cmsbuild commented Nov 19, 2024

mandrenguyen commented Nov 19, 2024

cmsbuild commented Nov 12, 2024 •

edited

Loading