Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary Rollback for DIP BeamSpot client #46737

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

francescobrivio
Copy link
Contributor

PR description:

This PR is a "forwardport" of #46736
Original description:

As reported on Mattermost (here) there is an issue with the publication of the online BeamSpot to DIP (and consequently to OMS) since online DQM was switched to CMSSW_14_1_patch1.

In this PR I'm temporarily rolling-back the changes introduced in #46614, i.e. we go back to reading the default input file BeamFitResults.txt instead of BeamFitResultsForDIP.txt which is in the wrong format, hence causing the DIP publication issue.

Since we have only ~1 week of data-taking left in 2024, the correct implementation will come for 2025 data-taking.

PR validation:

14_1_X backport to be tested in P5

Backport:

Not a backport. 14_1_X backport provided in #46736

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 19, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • DQM/Integration (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58a115/42954/summary.html
COMMIT: cced508
CMSSW: CMSSW_14_2_X_2024-11-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46737/42954/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58a115/42964/summary.html
COMMIT: cced508
CMSSW: CMSSW_14_2_X_2024-11-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46737/42964/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3595287 into cms-sw:master Nov 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants