Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_X] Temporary Rollback for DIP BeamSpot client #46736

Merged

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Nov 19, 2024

PR description:

As reported on Mattermost (here) there is an issue with the publication of the online BeamSpot to DIP (and consequently to OMS) since online DQM was switched to CMSSW_14_1_patch1.

In this PR I'm temporarily rolling-back the changes introduced in #46614, i.e. we go back to reading the default input file BeamFitResults.txt instead of BeamFitResultsForDIP.txt which is in the wrong format, hence causing the DIP publication issue.

Since we have only ~1 week of data-taking left in 2024, the correct implementation will come for 2025 data-taking.

PR validation:

To be tested at P5.

Backport:

Given the urgency I'm opening the 14_1_X PR first and will take care later of the master PR.
EDIT: backport of #46737

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 19, 2024

A new Pull Request was created by @francescobrivio for CMSSW_14_1_X.

It involves the following packages:

  • DQM/Integration (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 19, 2024

cms-bot internal usage

@francescobrivio
Copy link
Contributor Author

urgent

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@francescobrivio
Copy link
Contributor Author

backport of #46737

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d6859/42953/summary.html
COMMIT: abc54ca
CMSSW: CMSSW_14_1_X_2024-11-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46736/42953/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565669
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565638
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

  • P5 tests successful

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovagnerini
Copy link

backport of #46737

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fd91f5f into cms-sw:CMSSW_14_1_X Nov 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants