-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14_1_X] Temporary Rollback for DIP BeamSpot client #46736
[14_1_X] Temporary Rollback for DIP BeamSpot client #46736
Conversation
A new Pull Request was created by @francescobrivio for CMSSW_14_1_X. It involves the following packages:
@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
urgent |
@cmsbuild please test |
backport of #46737 |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
backport of #46737 |
+1 |
PR description:
As reported on Mattermost (here) there is an issue with the publication of the online BeamSpot to DIP (and consequently to OMS) since online DQM was switched to CMSSW_14_1_patch1.
In this PR I'm temporarily rolling-back the changes introduced in #46614, i.e. we go back to reading the default input file
BeamFitResults.txt
instead ofBeamFitResultsForDIP.txt
which is in the wrong format, hence causing the DIP publication issue.Since we have only ~1 week of data-taking left in 2024, the correct implementation will come for 2025 data-taking.
PR validation:
To be tested at P5.
Backport:
Given the urgency I'm opening the 14_1_X PR first and will take care later of the master PR.
EDIT: backport of #46737