Handle ZDC in L1TriggerObjectsTxtWriter

[JHiltbrand]

PR description:

Allow the L1TriggerObjectsTxtWriter to handle ZDC channels in addition to the usual HCAL channels.

ATTN: @abdoulline @hjbossi

PR validation:

Performed a typical ./genLUT.sh dumpAll-and-generate routine with GT 141X_dataRun3_HLT_v1 and obtained an L1TriggerObjects.txt file with ZDC channels and associated gains/pedestals included as expected.

I don't believe any validation workflows should be affected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46538/42400

[cmsbuild]

A new Pull Request was created by @JHiltbrand for master.

It involves the following packages:

• CaloOnlineTools/HcalOnlineDb (db)

@atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @missirol, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[JHiltbrand]

Seems like four tests failed to run in their entirety. Not sure about the return code...

15:27:13 processing: ERROR executing  cd 2024.000001_RunJetMET02024D_10k; das-up-to-nevents.py -d /JetMET0/Run2024D-v1/RAW -e 10000 -pc > step1_dasquery.log  2>&1;  ret= 256
15:27:13 processing: ERROR executing  cd 2024.001001_RunZeroBias2024D_10k; das-up-to-nevents.py -d /ZeroBias/Run2024D-v1/RAW -e 10000 -pc > step1_dasquery.log  2>&1;  ret= 256
15:27:13 processing: ERROR executing  cd 2024.100001_RunJetMET02024C_10k; das-up-to-nevents.py -d /JetMET0/Run2024C-v1/RAW -e 10000 -pc > step1_dasquery.log  2>&1;  ret= 256
15:27:13 processing: ERROR executing  cd 2024.101001_RunZeroBias2024C_10k; das-up-to-nevents.py -d /ZeroBias/Run2024C-v1/RAW -e 10000 -pc > step1_dasquery.log  2>&1;  ret= 256

[abdoulline]

Seems like four tests failed to run in their entirety. Not sure about the return code...

15:27:13 processing: ERROR executing  cd 2024.000001_RunJetMET02024D_10k; das-up-to-nevents.py -d /JetMET0/Run2024D-v1/RAW -e 10000 -pc > step1_dasquery.log  2>&1;  ret= 256
15:27:13 processing: ERROR executing  cd 2024.001001_RunZeroBias2024D_10k; das-up-to-nevents.py -d /ZeroBias/Run2024D-v1/RAW -e 10000 -pc > step1_dasquery.log  2>&1;  ret= 256
15:27:13 processing: ERROR executing  cd 2024.100001_RunJetMET02024C_10k; das-up-to-nevents.py -d /JetMET0/Run2024C-v1/RAW -e 10000 -pc > step1_dasquery.log  2>&1;  ret= 256
15:27:13 processing: ERROR executing  cd 2024.101001_RunZeroBias2024C_10k; das-up-to-nevents.py -d /ZeroBias/Run2024C-v1/RAW -e 10000 -pc > step1_dasquery.log  2>&1;  ret= 256

These must be DAS (samples files access) errors...

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51f044/42443/summary.html
COMMIT: a94d40a
CMSSW: CMSSW_14_2_X_2024-10-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46538/42443/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

• 2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
• 2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
• 2024.1000012024.100001_RunJetMET02024C_10k/step1_dasquery.log

Expand to see more relval errors ...

• 2024.101001
• 2024.000001
• 2024.001001
• 2024.100001
• 2024.101001

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3569372
• DQMHistoTests: Total failures: 406
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3568946
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 201 log files, 171 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

ignore tests-rejected with ib-failure
Failures are clearly not related to PR

[perrotta]

+db

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1