Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symlinks for PATH and PYTHONPATH #9488

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Oct 30, 2024

backport of #9487
plus the extra commits 720bf83

This allows SCRAM to select dedicated bin and pythonpath for externals which are build for multiple archs.
This also drop py2 support for scram tools files

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2024

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_2_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5860f1/42470/summary.html
COMMIT: aa158c4
CMSSW: CMSSW_14_2_X_2024-10-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9488/42470/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5860f1/42470/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5860f1/42470/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testPrintTkMaps had ERRORS

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

+externals

unit tests failure is due to wrong unit test script https://github.com/cms-sw/cmssw/blob/master/DQM/TrackerRemapper/test/testPrintTkMaps.sh#L10

@smuzaffar smuzaffar merged commit e5caefc into IB/CMSSW_14_2_X/master Oct 30, 2024
9 of 10 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_2_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the fix-py3-path-symlinks branch November 3, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants