-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.1.X] make AlcaBeamMonitor
hoard less memory
#46465
[14.1.X] make AlcaBeamMonitor
hoard less memory
#46465
Conversation
…d of storing raw vertices
type performance-improvements |
A new Pull Request was created by @mmusich for CMSSW_14_1_X. It involves the following packages:
@antoniovagnerini, @atpathak, @cmsbuild, @consuegs, @francescobrivio, @nothingface0, @perrotta, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
@cmsbuild, please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
@cms-sw/db-l2 @cms-sw/dqm-l2 I think we're expecting a patch for HI data-taking soon. It would be great to get this in, please have a look. |
+1 |
+db
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #46451
PR description:
This PR is meant to partially address #42995 by means of storing the vertex position and errors for the vertices of interest in a dedicated
struct
withinBeamSpotInfo
instead of copying the rawreco::Vertex
objects directly in it.PR validation:
cmssw
compiles, see validation in the master PR #46451If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of #46451 for 2024 ppRef and HIon operations.