-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make AlcaBeamMonitor
hoard less memory
#46451
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46451/42308 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@antoniovagnerini, @atpathak, @cmsbuild, @consuegs, @francescobrivio, @nothingface0, @perrotta, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
6b1946c
to
43bf430
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46451/42311 |
Pull request #46451 was updated. @antoniovagnerini, @atpathak, @cmsbuild, @consuegs, @francescobrivio, @nothingface0, @perrotta, @rvenditti, @syuvivida, @tjavaid can you please check and sign again. |
…d of storing raw vertices
43bf430
to
1cff3b2
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46451/42312 |
Pull request #46451 was updated. @antoniovagnerini, @atpathak, @cmsbuild, @consuegs, @francescobrivio, @nothingface0, @perrotta, @rvenditti, @syuvivida, @tjavaid can you please check and sign again. |
@cmsbuild, please test |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
+db |
type performance-improvements |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is meant to partially address #42995 by means of storing the vertex position and errors for the vertices of interest in a dedicated
struct
withinBeamSpotInfo
instead of copying the rawreco::Vertex
objects directly in it.PR validation:
cmssw
compiles, will be tested in PR tests.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but will be backported to (at least) 14.1.X if successful.