Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make AlcaBeamMonitor hoard less memory #46451

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 18, 2024

PR description:

This PR is meant to partially address #42995 by means of storing the vertex position and errors for the vertices of interest in a dedicated struct within BeamSpotInfo instead of copying the raw reco::Vertex objects directly in it.

PR validation:

cmssw compiles, will be tested in PR tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported to (at least) 14.1.X if successful.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/BeamMonitor (dqm, db)

@antoniovagnerini, @atpathak, @cmsbuild, @consuegs, @francescobrivio, @nothingface0, @perrotta, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @francescobrivio, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46451 was updated. @antoniovagnerini, @atpathak, @cmsbuild, @consuegs, @francescobrivio, @nothingface0, @perrotta, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46451 was updated. @antoniovagnerini, @atpathak, @cmsbuild, @consuegs, @francescobrivio, @nothingface0, @perrotta, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 19, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8749e7/42305/summary.html
COMMIT: 1cff3b2
CMSSW: CMSSW_14_2_X_2024-10-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46451/42305/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3673027
  • DQMHistoTests: Total failures: 437
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3672570
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 205 log files, 176 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+db

@mmusich
Copy link
Contributor Author

mmusich commented Oct 21, 2024

type performance-improvements

@antoniovagnerini
Copy link

+1

  • P5 tests successful

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 90d3d0c into cms-sw:master Oct 21, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_AlcaBeamMonitor_redux branch October 22, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants