[LLVM Analyzer][L1] Cleanup LLVM analyzer warnings #46411

iarspider · 2024-10-16T15:28:07Z

PR description:

See report

PR validation:

Bot tests

cmsbuild · 2024-10-16T15:28:34Z

cms-bot internal usage

cmsbuild · 2024-10-16T15:33:26Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46411/42264

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/TrackFindingTracklet/src/TrackletCalculatorDisplaced.cc modified in PR(s): Several improvements to L1 tracking code #46360

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46411/42264/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46411/42264/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

iarspider · 2024-10-16T15:36:21Z

please test

cmsbuild · 2024-10-16T15:37:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46411/42265

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/TrackFindingTracklet/src/TrackletCalculatorDisplaced.cc modified in PR(s): Several improvements to L1 tracking code #46360

cmsbuild · 2024-10-16T15:37:40Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

L1Trigger/DTTriggerPhase2 (upgrade, l1)
L1Trigger/DTTriggerServerPhi (l1)
L1Trigger/L1TCalorimeter (l1)
L1Trigger/L1THGCal (upgrade, l1)
L1Trigger/L1TMuonEndCap (l1)
L1Trigger/L1TMuonOverlap (l1)
L1Trigger/TrackFindingTMTT (l1)
L1Trigger/TrackFindingTracklet (l1)
L1Trigger/TrackTrigger (upgrade, l1)
L1TriggerConfig/L1GtConfigProducers (l1)

@Moanwar, @aloeliger, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @battibass, @dinyar, @erikbutz, @eyigitba, @jbsauvan, @lgray, @missirol, @mmusich, @skinnari, @sviret, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-10-16T15:53:52Z

-1

Failed Tests: Build HeaderConsistency ClangBuild
Size: This PR adds an extra 84KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8e0dd/42244/summary.html
COMMIT: 09cac6a
CMSSW: CMSSW_14_2_X_2024-10-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46411/42244/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@bsunanda Run3-hcx377A Correct a few test scripts in CondTools/Geometry #46386

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8e0dd/42244/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8e0dd/42244/git-merge-result

Build

I found compilation error when building:

In file included from src/L1Trigger/L1TMuonOverlap/interface/OMTFSorter.h:12,
                 from src/L1Trigger/L1TMuonOverlap/interface/OMTFReconstruction.h:23,
                 from src/L1Trigger/L1TMuonOverlap/plugins/L1TMuonOverlapTrackProducer.h:19,
                 from src/L1Trigger/L1TMuonOverlap/plugins/L1TMuonOverlapTrackProducer.cc:10:
src/L1Trigger/L1TMuonOverlap/interface/AlgoMuon.h: In constructor 'AlgoMuon::AlgoMuon(int, int, int, int, int, int, int, int, int)':
src/L1Trigger/L1TMuonOverlap/interface/AlgoMuon.h:90:16: error: 'AlgoMuon::m_rhitNumb' will be initialized after [-Werror=reorder]
   90 |   unsigned int m_rhitNumb;
      |                ^~~~~~~~~~
src/L1Trigger/L1TMuonOverlap/interface/AlgoMuon.h:86:7: error:   'int AlgoMuon::m_phiRHit' [-Werror=reorder]
   86 |   int m_phiRHit;
      |       ^~~~~~~~~

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package L1Trigger/TrackFindingTMTT
>> Entering Package L1Trigger/TrackFindingTracklet
>> Entering Package L1Trigger/TrackTrigger
>> Entering Package L1TriggerConfig/L1GtConfigProducers
>> Compile sequence completed for CMSSW CMSSW_14_2_X_2024-10-15-2300
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_2_X_2024-10-15-2300/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package CondTools/Geometry
Entering library rule at src/CondTools/Geometry/plugins
>> Compiling edm plugin src/CondTools/Geometry/plugins/CSCRecoIdealDBLoader.cc

iarspider · 2024-10-17T09:10:02Z

please test

cmsbuild · 2024-10-17T11:14:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46411/42279

cmsbuild · 2024-10-17T11:15:03Z

Pull request #46411 was updated. @Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

iarspider · 2024-10-17T11:29:43Z

please test

cmsbuild · 2024-10-17T15:11:24Z

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8e0dd/42266/summary.html
COMMIT: 975e1e1
CMSSW: CMSSW_14_2_X_2024-10-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46411/42266/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3335129
DQMHistoTests: Total failures: 450
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3334659
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

aloeliger · 2024-10-21T12:11:59Z

L1Trigger/DTTriggerPhase2/src/MuonPathAssociator.cc

@@ -589,7 +589,7 @@ void MuonPathAssociator::correlateMPaths(edm::Handle<DTDigiCollection> dtdigis,
        sl3 = 0;
        for (auto SL3metaPrimitive = SL3metaPrimitives.begin(); SL3metaPrimitive != SL3metaPrimitives.end();
             ++SL3metaPrimitive, sl3++) {
-          if (useFitSL3[sl3])
+          [[clang::suppress]] if (useFitSL3[sl3])


Forgive my ignorance, but are these things I should fix, or task the relevant L1T person to fix, instead of suppressing warnings?

aloeliger · 2024-10-28T10:42:50Z

+l1

Moanwar · 2024-10-28T10:46:53Z

+Upgrade

cmsbuild · 2024-10-28T10:47:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-10-28T13:48:34Z

+1

cmsbuild added this to the CMSSW_14_2_X milestone Oct 16, 2024

cmsbuild added l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Oct 16, 2024

iarspider force-pushed the iarspider-patches-20241016-3 branch 2 times, most recently from e3ac8f1 to 413dd3b Compare October 16, 2024 15:30

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 16, 2024

iarspider force-pushed the iarspider-patches-20241016-3 branch from 413dd3b to 09cac6a Compare October 16, 2024 15:35

cmsbuild added code-checks-pending and removed code-checks-rejected labels Oct 16, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 16, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 16, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 16, 2024

iarspider force-pushed the iarspider-patches-20241016-3 branch from 09cac6a to 5e757b3 Compare October 17, 2024 09:09

cmsbuild removed tests-rejected code-checks-approved labels Oct 17, 2024

[LLVM Analyzer][L1] Cleanup LLVM analyzer warnings

975e1e1

iarspider force-pushed the iarspider-patches-20241016-3 branch from bfe0fdb to 975e1e1 Compare October 17, 2024 11:13

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 17, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 17, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 17, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 17, 2024

aloeliger reviewed Oct 21, 2024

View reviewed changes

cmsbuild mentioned this pull request Oct 23, 2024

[HGCAL trigger] Fix rounding in floating point compression #46491

Merged

cmsbuild added l1-approved and removed l1-pending labels Oct 28, 2024

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Oct 28, 2024

cmsbuild added orp-approved and removed orp-pending labels Oct 28, 2024

cmsbuild merged commit 39fa1fd into cms-sw:master Oct 28, 2024
11 checks passed

cmsbuild mentioned this pull request Oct 28, 2024

[NanoAOD] Add ParticleNet-based Muon ID (Rework of #46153) #46273

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LLVM Analyzer][L1] Cleanup LLVM analyzer warnings #46411

[LLVM Analyzer][L1] Cleanup LLVM analyzer warnings #46411

iarspider commented Oct 16, 2024

cmsbuild commented Oct 16, 2024 •

edited

Loading

cmsbuild commented Oct 16, 2024

iarspider commented Oct 16, 2024

cmsbuild commented Oct 16, 2024

cmsbuild commented Oct 16, 2024

cmsbuild commented Oct 16, 2024

iarspider commented Oct 17, 2024

cmsbuild commented Oct 17, 2024

cmsbuild commented Oct 17, 2024

iarspider commented Oct 17, 2024

cmsbuild commented Oct 17, 2024

aloeliger Oct 21, 2024

aloeliger commented Oct 28, 2024

Moanwar commented Oct 28, 2024

cmsbuild commented Oct 28, 2024

mandrenguyen commented Oct 28, 2024

[LLVM Analyzer][L1] Cleanup LLVM analyzer warnings #46411

[LLVM Analyzer][L1] Cleanup LLVM analyzer warnings #46411

Conversation

iarspider commented Oct 16, 2024

PR description:

PR validation:

cmsbuild commented Oct 16, 2024 • edited Loading

cmsbuild commented Oct 16, 2024

iarspider commented Oct 16, 2024

cmsbuild commented Oct 16, 2024

cmsbuild commented Oct 16, 2024

cmsbuild commented Oct 16, 2024

Build

Clang Build

iarspider commented Oct 17, 2024

cmsbuild commented Oct 17, 2024

cmsbuild commented Oct 17, 2024

iarspider commented Oct 17, 2024

cmsbuild commented Oct 17, 2024

Comparison Summary

aloeliger Oct 21, 2024

Choose a reason for hiding this comment

aloeliger commented Oct 28, 2024

Moanwar commented Oct 28, 2024

cmsbuild commented Oct 28, 2024

mandrenguyen commented Oct 28, 2024

cmsbuild commented Oct 16, 2024 •

edited

Loading