Run3-hcx373Y Correct HcalTopology class - backport from #46308 and #46309

[bsunanda]

PR description:

Correct HcalTopology class - backport from #46308 and #46309. This is abug fixing PR

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #46308 (14_2_X) and #46309 (14_1_X)

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_14_0_X.

It involves the following packages:

• Geometry/CaloTopology (geometry)
• Geometry/HcalCommonData (geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @fabiocos, @martinamalberti, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Run3-hcx373 Correct the HcalTopology class for 2 new geometry modes #46308

[cmsbuild]

cms-bot internal usage

[bsunanda]

@cmsbuild Please test

[smuzaffar]

please test

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d2eb3/42106/summary.html
COMMIT: 895a951
CMSSW: CMSSW_14_0_X_2024-10-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46332/42106/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 4.53

----- Begin Fatal Exception 10-Oct-2024 18:43:23 CEST-----------------------
An exception of category 'LogicalFileNameNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
Exception Message:
RootFileSequenceBase::initTheFile()
Logical file name '++ echo /store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root' was not found in the file catalog.
If you wanted a local file, you forgot the 'file:' prefix
before the file name in your configuration file.
----- End Fatal Exception -------------------------------------------------

• 136.731

----- Begin Fatal Exception 10-Oct-2024 18:43:29 CEST-----------------------
An exception of category 'LogicalFileNameNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
Exception Message:
RootFileSequenceBase::initTheFile()
Logical file name '++ echo /store/data/Run2016B/SinglePhoton/RAW/v2/000/274/199/00000/CA646D43-8526-E611-A6D9-02163E014300.root' was not found in the file catalog.
If you wanted a local file, you forgot the 'file:' prefix
before the file name in your configuration file.
----- End Fatal Exception -------------------------------------------------

• 136.793

----- Begin Fatal Exception 10-Oct-2024 18:43:30 CEST-----------------------
An exception of category 'LogicalFileNameNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
Exception Message:
RootFileSequenceBase::initTheFile()
Logical file name '++ echo /store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/E40E8D49-B68C-E711-B49E-02163E019E66.root' was not found in the file catalog.
If you wanted a local file, you forgot the 'file:' prefix
before the file name in your configuration file.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 139.001
• 136.874
• 140.023
• 140.043
• 4.22
• 140.063
• 141.044
• 141.042
• 141.046
• 140.56
• 158.01
• 136.7611
• 136.8311
• 136.88811
• 1000.0
• 1001.0
• 2500.4

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d2eb3/42106/summary.html
COMMIT: 895a951
CMSSW: CMSSW_14_0_X_2024-10-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46332/42106/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1000.0 step 2
1001.0 step 2
136.731 step 2
136.7611 step 2
136.793 step 2
136.8311 step 2
136.874 step 2
136.88811 step 2
139.001 step 2
140.023 step 2
140.043 step 2
140.063 step 2
140.56 step 2
141.042 step 2
141.044 step 2
141.046 step 2
158.01 step 2
2500.4 step 2
4.22 step 2
4.53 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 11510 lines to the logs
• Reco comparison results: 46 differences found in the comparisons
• DQMHistoTests: Total files compared: 28
• DQMHistoTests: Total histograms compared: 2518090
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2518069
• DQMHistoTests: Total skipped: 12
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 27 files compared)
• Checked 159 log files, 113 edm output root files, 28 DQM output files
• TriggerResults: no differences found

[bsunanda]

+geometry

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

backport of #46308

[mandrenguyen]

hold
As agreed at the ORP meeting on Oct 15.
If this needs to be revived in this (closed) release it will need to be carefully validated with PPD.

[cmsbuild]

Pull request has been put on hold by @mandrenguyen
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[mandrenguyen]

closing, feel free to object.