Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in DeDxEstimatorRekeyer #46312

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

This PR fixes the issue reported in #46307

PR validation:

Tested by running over the crashing HIForward event reported by T0.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport to be made for 14_1_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e70279/42059/summary.html
COMMIT: 221cd80
CMSSW: CMSSW_14_2_X_2024-10-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46312/42059/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

urgent

@cmsbuild cmsbuild added the urgent label Oct 9, 2024
@jfernan2
Copy link
Contributor

jfernan2 commented Oct 9, 2024

+1

@mandrenguyen
Copy link
Contributor

ping @cms-sw/xpog-l2

@hqucms
Copy link
Contributor

hqucms commented Oct 9, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 753f1e8 into cms-sw:master Oct 9, 2024
11 checks passed
@stahlleiton stahlleiton deleted the Fix_CMSSW_14_2_X branch October 10, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants