Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.1.X] Miscellaneous fixes for HLT online DQM #46301

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 8, 2024

backport of #46245

PR description:

This PR bundles together a couple of fixes for the HLT online DQM:

%MSG-w TrackProducerBase:  TrackRefitter:hltrefittedForPixelDQM  03-Oct-2024 22:56:25 CEST Run: 386554 Event: 2607599
BeamSpot is not valid
%MSG
%MSG-e TrackRefitter:  TrackRefitter:hltrefittedForPixelDQM  03-Oct-2024 22:56:25 CEST Run: 386554 Event: 2607599
BeamSpot is (0,0,0), it is probably because is not valid in the event
%MSG

I believe the issue is that the current hltrefittedForPixelDQM instance clones the one used for offline (refittedForPixelDQM) which ultimately clones the template with the offline parameters:

beamSpot = cms.InputTag("offlineBeamSpot"),

  • secondly, also looking at the HLT quick collection many of the plots are empty, I believe due the usage of deprecated trigger paths in input

The two issues are addressed at 97a6d8e and 45dee81 respectively.

PR validation:

See results of the DQM playback in the master version: #46245 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #46245 to CMSSW_14_0_X for 2024 data-taking operations.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 8, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • DQM/HLTEvF (hlt, dqm)
  • DQMOffline/Trigger (dqm)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @cericeci, @jhgoh, @missirol, @mtosi, @rociovilar, @silviodonato, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Oct 8, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2878a/42044/summary.html
COMMIT: 45dee81
CMSSW: CMSSW_14_1_X_2024-10-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46301/42044/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+1

@mmusich
Copy link
Contributor Author

mmusich commented Oct 8, 2024

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4d2a1dd into cms-sw:CMSSW_14_1_X Oct 8, 2024
9 checks passed
@mmusich mmusich deleted the mm_refurbish_HLT_DQM_14_1X branch October 8, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants