-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous fixes for HLT online DQM #46245
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46245/42070 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
17e3bf7
to
d64a38e
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46245/42072 |
Pull request #46245 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again. |
d64a38e
to
3c5e8fe
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46245/42076 |
Pull request #46245 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again. |
@cmsbuild, please test |
playback kindly provided by @nothingface0 looks good. Pixel residuals: Object Monitor: |
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
+hlt
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR bundles together a couple of fixes for the HLT online DQM:
I believe the issue is that the current
hltrefittedForPixelDQM
instance clones the one used for offline (refittedForPixelDQM
) which ultimately clones the template with the offline parameters:cmssw/RecoTracker/TrackProducer/python/TrackRefitter_cfi.py
Line 5 in 180e6a5
The two issues are addressed at 3bf61e3 and 17e3bf7 respectively.
PR validation:
None, will need to be tested via DQM replay
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, might backport to 14.1.x and 14.0.x for 2024 data-taking purposes.