Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve QTest Pixel DQM (BP to [14_1_X]) #45930

Merged

Conversation

alaperto
Copy link
Contributor

@alaperto alaperto commented Sep 5, 2024

PR description:

Changes to Pixel DQM Quality Test

  1. L1 cluster size:
    Issue: HI runs from 2023 and early 2024 pp runs had cluster size > 6 (outside allowed range)
    GUI plot: https://tinyurl.com/2ccppw6k
    GUI summary: https://tinyurl.com/2dysgbhe
    Details: slides 5-6-7
    Change: increase error threshold for the QTest from 6 to 7 (L1 mean cluster size)

  2. Cluster charge (BPix and FPix):
    Issue: 2024 pp runs have cluster charge close to error threshold (values established 5 years ago, during Run 2)
    GUI plot: https://tinyurl.com/22n2bwvv
    GUI summary: https://tinyurl.com/2xn3uu59
    Details: slides 2-3-4
    Change: reduce error threshold to 15k electrons (BPix and FPix mean cluster charge)

PR validation:

Simple change to config numerical values: no validation done

About backport

This is a backport to 14_1_X of #45840

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

A new Pull Request was created by @alaperto for CMSSW_14_1_X.

It involves the following packages:

  • DQM/SiPixelPhase1Config (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@arossi83, @fioriNTU, @idebruyn, @jandrea, @mmusich, @sroychow, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild cmsbuild added the trk label Sep 5, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Sep 6, 2024

backport of #45840

@tjavaid
Copy link

tjavaid commented Sep 6, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dee8d7/41364/summary.html
COMMIT: 598915e
CMSSW: CMSSW_14_1_X_2024-09-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45930/41364/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 17 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328391
  • DQMHistoTests: Total failures: 1303
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3327068
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Sep 6, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c1f0cb9 into cms-sw:CMSSW_14_1_X Sep 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants