Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve QTest Pixel DQM #45840

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

alaperto
Copy link
Contributor

@alaperto alaperto commented Aug 30, 2024

PR description:

Changes to Pixel DQM Quality Test

  1. L1 cluster size:
    Issue: HI runs from 2023 and early 2024 pp runs had cluster size > 6 (outside allowed range)
    GUI plot: https://tinyurl.com/2ccppw6k
    GUI summary: https://tinyurl.com/2dysgbhe
    Details: slides 5-6-7
    Change: increase error threshold for the QTest from 6 to 7 (L1 mean cluster size)

  2. Cluster charge (BPix and FPix):
    Issue: 2024 pp runs have cluster charge close to error threshold (values established 5 years ago, during Run 2)
    GUI plot: https://tinyurl.com/22n2bwvv
    GUI summary: https://tinyurl.com/2xn3uu59
    Details: slides 2-3-4
    Change: reduce error threshold to 15k electrons (BPix and FPix mean cluster charge)

PR validation:

Simple change to config numerical values: no validation done

About backport

This PR is intended for 2024 data taking.
Backports to
14_0_X: #45841
14_0_X: #45930

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alaperto for master.

It involves the following packages:

  • DQM/SiPixelPhase1Config (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@arossi83, @fioriNTU, @idebruyn, @jandrea, @mmusich, @sroychow, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@sroychow
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-469110/41198/summary.html
COMMIT: 598915e
CMSSW: CMSSW_14_2_X_2024-08-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45840/41198/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 109 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328315
  • DQMHistoTests: Total failures: 2881
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3325414
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@alaperto
Copy link
Contributor Author

alaperto commented Sep 4, 2024

Can someone sign this PR?

@sroychow
Copy link
Contributor

sroychow commented Sep 5, 2024

@cms-sw/dqm-l2 can this be signed? we want the change to be deployed for data taking ASAP.

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

+1

  • @alaperto , would you also like to open a backport PR to CMSSW_14_1_X ? Thanks!

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@alaperto
Copy link
Contributor Author

alaperto commented Sep 5, 2024

Hi @tjavaid , do you mean BP to [14_0_X]? --> #45841
Or should I really create BP to [14_1_X]?

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

Hi @tjavaid , do you mean BP to [14_0_X]? --> #45841 Or should I really create BP to [14_1_X]?

Hi @alaperto , recently master branch was changed to CMSSW_14_2_X. Therefore, we suggest also to open a backport PR to CMSSW_14_1_X.

@alaperto
Copy link
Contributor Author

alaperto commented Sep 5, 2024

Hi @tjavaid here it is BP to 14_1_X: #45930

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4859ace into cms-sw:master Sep 6, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants