-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Golden Workflows for 2022 and 2023 Data #45836
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45836/41579 |
A new Pull Request was created by @AdrianoDee for master. It involves the following packages:
@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
b350636
to
bfd524b
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45836/41581 |
Pull request #45836 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again. |
bfd524b
to
6611de6
Compare
6611de6
to
e3c1e48
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45836/41593 |
Pull request #45836 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again. |
test parameters:
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45836/41595 |
Pull request #45836 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again. |
please test |
+1 Size: This PR adds an extra 72KB to repository Comparison SummarySummary:
|
+pdmv |
Hi @AdrianoDee Thx. |
Hi @srimanob, yes, this was a trick to continue testing the 2024 menu on 2023 samples until 2024 RelVals were out. Now we can most probably move this to |
yes, provided we have workflows that run |
Hi @AdrianoDee |
Hi @srimanob I'd split it into another cleanup PR. |
+Upgrade There will be follow up cleanup PR. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Following the setup introduced in #45055 for 2024 data wfs, this PR proposes to add also the equivalent set of workflows for 2022 and 2023 data. As in the parent PR a smaller set of wfs is added to
relval_standard.py
just to keep testing the machinery in the IBs, while the higher stats wfs are inrelval_data_highstats.py
.PR validation:
E.g.
runTheMatrix.py -w data -l 2022.000005, 2023.001005
.