-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx359W Modify the testing code in some packages in RecLocalCalo, SimG4CMS and Validation because of changes made in the Configuration/Geometry area for Phase2 scenarios #45812
Conversation
…d Validation because of changes made in the Configuration/Geometry area for Phase2 scenarios
A new Pull Request was created by @bsunanda for CMSSW_14_1_X. It involves the following packages:
@Dr15Jones, @antoniovagnerini, @bsunanda, @civanch, @cmsbuild, @jfernan2, @makortel, @mandrenguyen, @mdhildreth, @nothingface0, @rvenditti, @srimanob, @subirsarkar, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@cmsbuild Please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
+1 |
+1 I would include these updates in 14_1_X to have geometry tests consistent with 2024 geometry |
@srimanob Please approve this PR |
@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid Please approve this PR |
+1 |
@srimanob Please approve this PR |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
type hgcal |
PR description:
Modify the testing code in some packages in RecLocalCalo, SimG4CMS and Validation because of changes made in the Configuration/Geometry area for Phase2 scenarios. These are backports of #45790 #45791 and #45793
PR validation:
Checked some of the modified scripts in present context
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backports of #45790 #45791 and #45793