Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx359W Modify the testing code in some packages in RecLocalCalo, SimG4CMS and Validation because of changes made in the Configuration/Geometry area for Phase2 scenarios #45812

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

bsunanda
Copy link
Contributor

PR description:

Modify the testing code in some packages in RecLocalCalo, SimG4CMS and Validation because of changes made in the Configuration/Geometry area for Phase2 scenarios. These are backports of #45790 #45791 and #45793

PR validation:

Checked some of the modified scripts in present context

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backports of #45790 #45791 and #45793

…d Validation because of changes made in the Configuration/Geometry area for Phase2 scenarios
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024

A new Pull Request was created by @bsunanda for CMSSW_14_1_X.

It involves the following packages:

  • RecoLocalCalo/HGCalRecAlgos (upgrade, reconstruction)
  • SimG4CMS/Calo (simulation)
  • Validation/Geometry (dqm, geometry)
  • Validation/HGCalValidation (dqm)

@Dr15Jones, @antoniovagnerini, @bsunanda, @civanch, @cmsbuild, @jfernan2, @makortel, @mandrenguyen, @mdhildreth, @nothingface0, @rvenditti, @srimanob, @subirsarkar, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @argiro, @cseez, @edjtscott, @fabiocos, @felicepantaleo, @hatakeyamak, @lecriste, @lgray, @martinamalberti, @missirol, @mmusich, @pfs, @rbartek, @rchatter, @rishabhCMS, @rovere, @sameasy, @sethzenz, @slomeo, @thomreis, @vandreev11, @vargasa, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024

cms-bot internal usage

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eded8c/41157/summary.html
COMMIT: 7be61b9
CMSSW: CMSSW_14_1_X_2024-08-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45812/41157/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328202
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328173
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Aug 28, 2024

+1

I would include these updates in 14_1_X to have geometry tests consistent with 2024 geometry

@bsunanda
Copy link
Contributor Author

@srimanob Please approve this PR

@bsunanda
Copy link
Contributor Author

@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid Please approve this PR

@tjavaid
Copy link

tjavaid commented Aug 28, 2024

+1

@bsunanda
Copy link
Contributor Author

@srimanob Please approve this PR

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

backport of #45790
#45791 and #45793

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7070984 into cms-sw:CMSSW_14_1_X Aug 31, 2024
9 checks passed
@mandrenguyen
Copy link
Contributor

type hgcal

@cmsbuild cmsbuild added the hgcal label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants