Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx359U Modify the testing code in Validation/Geometry and SimG4CMS/Calo in view of changes made in the Configuration/Geometry area for Phase2 scenarios #45793

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

bsunanda
Copy link
Contributor

PR description:

Modify the testing code in Validation/Geometry and SimG4CMS/Calo in view of changes made in the Configuration/Geometry area for Phase2 scenarios

PR validation:

Tested the scripts

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

…iew of changes made in the Configuration/Geometry area for Phase2 scenarios
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • SimG4CMS/Calo (simulation)
  • Validation/Geometry (geometry, dqm)

@Dr15Jones, @antoniovagnerini, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @fabiocos, @felicepantaleo, @martinamalberti, @missirol, @rbartek, @rishabhCMS, @rovere, @slomeo, @thomreis, @vargasa, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ac7c2/41139/summary.html
COMMIT: c77daef
CMSSW: CMSSW_14_1_X_2024-08-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45793/41139/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor

civanch commented Aug 26, 2024

+1

regression problem - MkFit WF

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@bsunanda
Copy link
Contributor Author

@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid Please approve this PR

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 28, 2024
@tjavaid
Copy link

tjavaid commented Aug 29, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit eae4235 into cms-sw:master Aug 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants