migrate calotowers creation code to use EcalPFRecHitThresholds

[mmusich]

PR description:

This PR the ECAL equivalent of #43329.
While our final aim is to fully deprecate calotowers, there is no clear ETA for that. Several POGs still use calotowers, specially at HLT. So, to ensure that correct HCAL thresholds are used in making calotowers, the safest way is to use the thresholds from GT.
That is what is done in this PR.
This PR was sparked by the observation that at the HLT we are using the following configuration:

EBThreshold = cms.double( 0.07 )
EEThreshold = cms.double( 0.3 )

which looks exceedingly low given that 0.3 GeV threshold in EE for all crystals is too small threshold to mitigate the noise in EE.
There are crystals in EE where the threshold is order of 10 GeV (reaching up to ~50 GeV or maybe even higher these days).
Indeed inspecting the last IOV of the EcalPFRecHitThresholdsRcd associated tag at HLT,

$ conddb list 140X_dataRun3_HLT_v3 | grep EcalPFRecHitThresholdsRcd
[2024-08-26 10:47:34,394] INFO: Connecting to pro [frontier://PromptProd/cms_conditions]
EcalPFRecHitThresholdsRcd                               -                                                 EcalPFRecHitThresholds_2018_v1_hlt                               

$ conddb list EcalPFRecHitThresholds_2018_v1_hlt
[2024-08-26 10:47:48,292] INFO: Connecting to pro [frontier://PromptProd/cms_conditions]
[2024-08-26 10:47:48,471] INFO: Listing with a limit of 500 IOVs, starting from the highest since. If you need to see more, please increase the limit of returned results.
Since: Run   Insertion Time       Payload                                   Object Type                      
-----------  -------------------  ----------------------------------------  ------------------------------   
1            2018-03-28 14:25:39  9f22e391bcdcabe1f9f13608961bbed938c8a05c  EcalCondObjectContainer<float>   
337349       2020-09-24 08:42:44  f965e090d8749785f3d9c290bb08f247b90bd9fe  EcalCondObjectContainer<float>   
347532       2022-02-10 10:03:50  6bf33ca11214dec349a05af31b1f4af8526ffb30  EcalCondObjectContainer<float>   
 
$ conddb dump 6bf33ca11214dec349a05af31b1f4af8526ffb30 > dump.xml 

I see rather large thresholds especially in EE:

This PR allows to change the logic of the code to use the EcalPFRecHitThresholds from GT instead of the fixed values.

PR validation:

Validation was purely technical: runTheMatrix.py - l limited --ibeos.
Physics implications should be checked by the relevant POGs.

EDIT: In the last push the new parameter EcalRecHitThresh is set to false, such that this PR is technically a no-op.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45803/41542

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoLocalCalo/CaloTowersCreator/src/CaloTowersCreator.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• RecoLocalCalo/CaloTowersCreator (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@apsallid, @missirol, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9934fd/41147/summary.html
COMMIT: beb3a90
CMSSW: CMSSW_14_1_X_2024-08-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45803/41147/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328202
• DQMHistoTests: Total failures: 5807
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3322375
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: found differences in 7 / 42 workflows

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[mmusich]

For the record, some discussion is included in CMSHLT-3320

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45803/41754

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoLocalCalo/CaloTowersCreator/src/CaloTowersCreator.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

[cmsbuild]

Pull request #45803 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

[mmusich]

type hlt-integration

• I am flagging this because it will be used for HLT (possibly next year)

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9934fd/41474/summary.html
COMMIT: 979e229
CMSSW: CMSSW_14_2_X_2024-09-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45803/41474/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 176 lines from the logs
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331158
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3331129
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1