-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to relval_gpu.py
for Alpaka and Pixel Triplets Alpaka Workflows
#45694
Conversation
enable gpu |
cms-bot internal usage |
@fwyzard let me know if this makes sense to you. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45694/41280
|
A new Pull Request was created by @AdrianoDee for master. It involves the following packages:
@AdrianoDee, @cmsbuild, @jfernan2, @kskovpen, @mandrenguyen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: Build BuildI found compilation error when building: SyntaxError: invalid syntax gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:2004: CompilePython] Error 1 gmake[1]: Target 'PostBuild' not remade because of errors. gmake[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-08-13-1100' gmake: *** [config/SCRAM/GMake/Makefile.rules:1890: src] Error 2 gmake: Target 'all' not remade because of errors. gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2 + eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-08-13-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)' ++ scram build outputlog >> Entering Package Configuration/PyReleaseValidation |
2d7742a
to
4f4ed59
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45694/41282
|
+heterogeneous |
@cms-sw/dqm-l2 @cms-sw/upgrade-l2 any comment on this? |
+1
|
@cms-sw/upgrade-l2 sorry to bother but this would be useful for a series of things (removing IB failures, monitoring Alpaka wfs and CUDA removal). Thanks ( : |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@AdrianoDee coming back to this: given the very visible impact on the memory, I guess we should resurrect #43952 even before figuring out a less cumbersome interface. I'll try to rebase it to the latest |
#45887 is a work-in-progress reimplementation, that also makes the ZVertexSoA collections run-time sized. |
@cms-sw/orp-l2 gentle ping ( : |
+1 |
@@ -33,11 +33,15 @@ The offsets currently in use are: | |||
* 0.402: Alpaka, pixel only quadruplets, portable | |||
* 0.403: Alpaka, pixel only quadruplets, portable vs. CPU validation | |||
* 0.404: Alpaka, pixel only quadruplets, portable profiling | |||
* 0.406: Alpaka, pixel only triplets, portable | |||
* 0.407: Alpaka, pixel only triplets, portable vs. CPU validation | |||
* 0.407: Alpaka, pixel only triplets, portable profiling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo.
PR description:
This PR proposes to:
*.406
,*.407
,*.408
Alpaka PixelOnly triplets wf (standard, profiling, validation);*.486
triplet equivalent of.482
(full reco + pixel-only);relval_gpu.py
;relval_gpu.py
(with D110 fixed after Alpaka Pixel: ReadinglayerStart
at Runtime and VariablethePitch*
#45421);