Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Reject badly measured tracks with very high values of qoverpError before trying to reconstruct displaced vertices #45569

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

swagata87
Copy link
Contributor

PR description:

An attempt to solve this issue #45520.
Backport of #45536, however, verbatim backport was not possible due to other changes introduced only in 14_1_X via #45212

PR validation:

Checked with following workflows:
12846.0_ZEE_14+2024 and 141.044_RunJetMET2023D

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @swagata87 for CMSSW_14_0_X.

It involves the following packages:

  • RecoParticleFlow/PFTracking (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@hatakeyamak, @lgray, @missirol, @mmarionncern, @rovere, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 27, 2024

cms-bot internal usage

@swagata87
Copy link
Contributor Author

type pf

@swagata87
Copy link
Contributor Author

@cmsbuild please test

@swagata87 swagata87 changed the title [14_0_X] Reject badly measured tracks with very high values of qoverpError before trying to reconstruct displaced vertices [14_0_X] Reject badly measured tracks with very high values of qoverpError before trying to reconstruct displaced vertices Jul 27, 2024
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bba514/40652/summary.html
COMMIT: 6f3a1c9
CMSSW: CMSSW_14_0_X_2024-07-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45569/40652/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 51 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342828
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342799
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

backport of #45536,

@swagata87
Copy link
Contributor Author

backport of #45536,

Note that this PR is not a verbatim backport of #45536. A verbatim backport is not possible due to some changes introduced between 14_0_X and 14_1_X in PF code base via #45212. However this backport does the same thing as the PR to master branch.

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 07eace3 into cms-sw:CMSSW_14_0_X Jul 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants