Reject badly measured tracks with very high values of qoverpError before trying to reconstruct displaced vertices

[swagata87]

PR description:

An attempt to solve this issue #45520

PR validation:

Checked with the workflow 12834.0_TTbar_14TeV+2024

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45536/41008

[cmsbuild]

A new Pull Request was created by @swagata87 for master.

It involves the following packages:

• RecoParticleFlow/PFTracking (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@hatakeyamak, @lgray, @missirol, @mmarionncern, @rovere, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

type pf

[jfernan2]

fixes #45520

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6289ea/40558/summary.html
COMMIT: 188940c
CMSSW: CMSSW_14_1_X_2024-07-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45536/40558/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

• 2500.2452500.245_hcalDPGCalibNANO140Xrun3/step2_hcalDPGCalibNANO140Xrun3.log

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 101 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3325254
• DQMHistoTests: Total failures: 2473
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3322761
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[swagata87]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6289ea/40625/summary.html
COMMIT: 188940c
CMSSW: CMSSW_14_1_X_2024-07-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45536/40625/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 165 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3325254
• DQMHistoTests: Total failures: 305
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3324929
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[swagata87]

this is the backport for 14_0_X #45569