fix packing of muon-shower objects for L1-uGT FED

[missirol]

PR description:

This PR applies the fix in #40822 to MuonPacker.cc. Right now, when L1REPACK is used to re-emulate L1T, gtStage2Raw is used to pack the L1-uGT data, gtStage2Raw.FwId equals 0x1150, and MuonPacker::getMuonShowers is not executed because the check touched by this PR fails (b/c 0x1150 < 0x10f01). This PR fixes the check in MuonPacker.cc, and moves it to a static function in MuonRawDigiTranslator for easier maintenance.

Tagging @dinyar to review (cc: @eyigitba).

PR validation:

None.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

I don't know if any backports are needed. To be decided by experts.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45519/40988

[cmsbuild]

A new Pull Request was created by @missirol for master.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)
• L1Trigger/L1TMuon (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@JanFSchulte, @Martin-Grunewald, @dinyar, @eyigitba, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[missirol]

Will this PR be reviewed ?

[mmusich]

@cmsbuild, please test

[mmusich]

type bug-fix

[dinyar]

Sorry, I looked at this last week and then just didn't send my message..

This looks good to me, thanks a lot for spotting the problem!

Cheers,
Dinyar

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-51b252/40665/summary.html
COMMIT: 4d7c9de
CMSSW: CMSSW_14_1_X_2024-07-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45519/40665/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 88 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3423961
• DQMHistoTests: Total failures: 2464
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3421477
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[missirol]

@dinyar @eyigitba

Is a backport to 14_0_X (and/or earlier releases) needed ? (that's not clear to me)

[mandrenguyen]

+1

[missirol]

Is a backport to 14_0_X (and/or earlier releases) needed ? (that's not clear to me)

FYI, I opened the backport to 14_0_X in #45593.

[eyigitba]

thanks @missirol ! I think it's better to backport this for any REPACK use with 140X