Fixes for CLANG_X+CPP20

[iarspider]

PR description:

See cms-sw/cmsdist#9288.

• Move definition of LHERunInfo::Process comparision operators before usage link
• Add include of Track.h to make class fully defined link

PR validation:

Bot tests

[iarspider]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45428/40879

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• GeneratorInterface/LHEInterface (generators)
• RecoTracker/FinalTrackSelectors (reconstruction)

@GurpreetSinghChahal, @SiewYan, @alberto-sanchez, @bbilin, @jfernan2, @mandrenguyen, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @alberto-sanchez, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mkirsano, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa9e2b/40342/summary.html
COMMIT: 4faa031
CMSSW: CMSSW_14_1_X_2024-07-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45428/40342/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3451616
• DQMHistoTests: Total failures: 851
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3450745
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 206 log files, 170 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

REMINDER @rappoccio, @sextonkennedy, @antoniovilela: This PR was tested with cms-sw/cmsdist#9288, please check if they should be merged together

[smuzaffar]

@cms-sw/generators-l2 , can you please review and sign it. This only moves the LHERunInfo::Process comparision operators . This is needed for CLANG 18 with c++20

[dan131riley]

Please review and sign, the errors are arguably correct and the changes are technically trivial

[smuzaffar]

@cms-sw/generators-l2 please review this PR?
@cms-sw/orp-l2 , we need this to go in. Without this clang compilation is failing for PR tests e.g see #45300 (comment) . Changes here are trivial and should not break any thing

[menglu21]

+1

[menglu21]

sorry for overlooking it

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1