Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing header in AllocatorConfig.h [14.0.x] #45360

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 2, 2024

PR description:

The header checks are failing with

src/HeterogeneousCore/AlpakaInterface/interface/AllocatorConfig.h:42:5: error: 'uint8_t' does not name a type
   42 |     uint8_t fillAllocationValue = 0xA5;
      |     ^~~~~~~
src/HeterogeneousCore/AlpakaInterface/interface/AllocatorConfig.h:6:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?

This PR adds the missing include header file.

PR validation:

Header checks should now pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45359.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 2, 2024

+heterogeneous

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 2, 2024

backport #45359

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 2, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 2, 2024

I'm not going to call this urgent, because the release builds fine.
However, in case we care about fixing the header check warnings in the 14.0.x IBs, please merge this at your convenience.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5b2d9/40187/summary.html
COMMIT: 4f2ea04
CMSSW: CMSSW_14_0_X_2024-07-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45360/40187/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9e5181f into cms-sw:CMSSW_14_0_X Jul 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants