Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing header in AllocatorConfig.h #45359

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 2, 2024

PR description:

The header checks are failing with

src/HeterogeneousCore/AlpakaInterface/interface/AllocatorConfig.h:42:5: error: 'uint8_t' does not name a type
   42 |     uint8_t fillAllocationValue = 0xA5;
      |     ^~~~~~~
src/HeterogeneousCore/AlpakaInterface/interface/AllocatorConfig.h:6:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?

This PR adds the missing include header file.

PR validation:

Header checks should now pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

The fix should be backported to 14.0.x.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 2, 2024

+heterogeneous

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 2, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 2, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 2, 2024

urgent

To fix the header checks that are failing in the IBs.

@cmsbuild cmsbuild added the urgent label Jul 2, 2024
@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 2, 2024

please test

@fwyzard fwyzard changed the title Add missing header Add missing header in AllocatorConfig.h Jul 2, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45359/40780

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe68c0/40186/summary.html
COMMIT: 1ffae5a
CMSSW: CMSSW_14_1_X_2024-07-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45359/40186/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345068
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild cmsbuild merged commit 422db62 into cms-sw:master Jul 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants