-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] Fix broken DQM/Integration
unit tests after streamers layout update
#45289
[14.0.X] Fix broken DQM/Integration
unit tests after streamers layout update
#45289
Conversation
type bug-fix |
A new Pull Request was created by @mmusich for CMSSW_14_0_X. It involves the following packages:
@syuvivida, @nothingface0, @antoniovagnerini, @cmsbuild, @tjavaid, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
test parameters:
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7e830/40033/summary.html Comparison SummarySummary:
|
REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with cms-sw/cmsdist#9264, please check if they should be merged together |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #45231
PR description:
The goal of this PR (together with its companion
cms-data
cms-data/DQM-Integration#8) is to update the input streamer files for several unit tests in theDQM/Integration
package. This follows the suggestion in #45224:TestDQMOnlineClient-beamhlt_dqm_sourceclient
silently fails in IBs #43108 (comment) to improve the test in order to be able to catch this sort of issue and actually implement the change => this is done in commit 7ca18b1Handle event meta data changes in streamer files [14_0] #44978 (comment), substitute the current files in cms-data (that have in the meanwhile become broken) with the new format => this is done in the companion
cms-data
PR UpdateDQM/Integration
unit tests input streamer files after streamers layout update cms-data/DQM-Integration#8 and in commit 4240ee5I profit of this PR to fix a small typo in commit c80197c.
PR validation:
Run successfully the following unit tests:
scram b runtests_TestDQMOnlineClient-beamhlt_dqm_sourceclient
scram b runtests_TestDQMOnlineClient-ecalgpu_dqm_sourceclient
scram b runtests_TestDQMOnlineClient-hcalgpu_dqm_sourceclient
scram b runtests_TestDQMOnlineClient-pixelgpu_dqm_sourceclient
scram b runtests_TestDQMOnlineClient-sistrip_approx_dqm_sourceclient
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of #45231 to the 2024 data-taking release.