Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Fix broken DQM/Integration unit tests after streamers layout update #45289

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 24, 2024

backport of #45231

PR description:

The goal of this PR (together with its companion cms-data cms-data/DQM-Integration#8) is to update the input streamer files for several unit tests in the DQM/Integration package. This follows the suggestion in #45224:

I profit of this PR to fix a small typo in commit c80197c.

PR validation:

Run successfully the following unit tests:

  • scram b runtests_TestDQMOnlineClient-beamhlt_dqm_sourceclient
  • scram b runtests_TestDQMOnlineClient-ecalgpu_dqm_sourceclient
  • scram b runtests_TestDQMOnlineClient-hcalgpu_dqm_sourceclient
  • scram b runtests_TestDQMOnlineClient-pixelgpu_dqm_sourceclient
  • scram b runtests_TestDQMOnlineClient-sistrip_approx_dqm_sourceclient

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #45231 to the 2024 data-taking release.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 24, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • DQM/Integration (dqm)
  • DQMServices/StreamerIO (dqm)

@syuvivida, @nothingface0, @antoniovagnerini, @cmsbuild, @tjavaid, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @barvic, @francescobrivio, @batinkov this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jun 24, 2024

test parameters:

@mmusich
Copy link
Contributor Author

mmusich commented Jun 24, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7e830/40033/summary.html
COMMIT: c80197c
CMSSW: CMSSW_14_0_X_2024-06-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45289/40033/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with cms-sw/cmsdist#9264, please check if they should be merged together

@tjavaid
Copy link

tjavaid commented Jun 25, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9264

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 47b2b87 into cms-sw:CMSSW_14_0_X Jun 25, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_updateDQMIntegrationStreamerFiles_14_0_X branch June 25, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants