-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQM/Integration
unit tests employing streamer files in input are silently broken
#45224
Comments
cms-bot internal usage |
A new Issue was created by @mmusich. @Dr15Jones, @makortel, @sextonkennedy, @antoniovilela, @smuzaffar, @rappoccio can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign dqm |
New categories assigned: dqm @rvenditti,@syuvivida,@tjavaid,@nothingface0,@antoniovagnerini you have been requested to review this Pull request/Issue and eventually sign? Thanks |
this is fixed at #45231 + cms-data/DQM-Integration#8 |
This issue is linked to #43108
After PR #44892 was merged, all the
DQM/Integration
unit tests employing streamer files in input are silently broken due to the change of the streamer layout, with errors of the type:This entails the following tests:
TestDQMOnlineClient-beamhlt_dqm_sourceclient
TestDQMOnlineClient-beamhlt_dqm_sourceclient-legacy
TestDQMOnlineClient-ecalgpu_dqm_sourceclient
TestDQMOnlineClient-hcalgpu_dqm_sourceclient
TestDQMOnlineClient-pixelgpu_dqm_sourceclient
As reported in #44892 (comment) the reason why the test technically still succeed despite the failures in de-serializing is due to feature of the
DQMStreamerReader
(see discussion at #43108 (comment)).A proposed (#44892 (comment)) solution would entail:
TestDQMOnlineClient-beamhlt_dqm_sourceclient
silently fails in IBs #43108 (comment) to improve the test in order to be able to catch this sort of issue and actually implement the change;cms-data
(that have in the meanwhile become broken) with the new format.Alternatively in #44892 (comment), it was proposed to create new "artificial" streamer file from scratch using the new release, where the files contains known data values and the unit tests show that those values are what is there when read.
Cc: @francescobrivio @nothingface0
The text was updated successfully, but these errors were encountered: