Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PileUpJetId] Backport of #45270 (Set jet phi for JEC) to 14_0_X #45271

Merged

Conversation

nurfikri89
Copy link
Contributor

Backport of #45270

PR description:

This PR resolves Issue #45099 by setting jet phi for the FactorizedJetCorrector since the latest JECs now has phi dependence.

PR validation:

  • tested using RunPromptReco.py and confirmed that the messages no longer appear.
  • passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2024

A new Pull Request was created by @nurfikri89 for CMSSW_14_0_X.

It involves the following packages:

  • RecoJets/JetProducers (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@mariadalfonso, @yslai, @seemasharmafnal, @ahinzmann, @nhanvtran, @jdamgov, @gkasieczka, @clelange, @schoef, @AnnikaStein, @rappoccio, @jdolen, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2024

cms-bot internal usage

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c2fbd5/39982/summary.html
COMMIT: 61e2433
CMSSW: CMSSW_14_0_X_2024-06-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45271/39982/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a6c951a into cms-sw:CMSSW_14_0_X Jun 24, 2024
10 checks passed
vince502 pushed a commit to vince502/cmssw that referenced this pull request Jun 25, 2024
…xJECInPuId

[PileUpJetId] Backport of cms-sw#45270 (Set jet phi for JEC) to 14_0_X
@nurfikri89 nurfikri89 deleted the portFrom141XTo140X_fixJECInPuId branch August 5, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants