Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noisy PileupJetIdProducer in Prompt reconstruction #45099

Closed
makortel opened this issue May 30, 2024 · 12 comments
Closed

Noisy PileupJetIdProducer in Prompt reconstruction #45099

makortel opened this issue May 30, 2024 · 12 comments

Comments

@makortel
Copy link
Contributor

makortel commented May 30, 2024

While investigating a PromptReco reproducer in #45089 (comment) I noticed many printouts along

%MSG-e FactorizedJetCorrectorCalculator:   PileupJetIdProducer:pileupJetIdCalculatorPUPPIDQM 29-May-2024 23:36:50 CEST  Run: 381067 Event: 682965806
jet phi is not set
%MSG

from pileupJetIdCalculatorPUPPIDQM and pileupJetIdCalculatorCHSDQM. In that example job, in 26466 events there were total of 4733863 printouts, corresponding to 767 MB of log.

Could these be silenced in some way?

@makortel
Copy link
Contributor Author

assign reconstruction, dqm

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction,dqm

@jfernan2,@mandrenguyen,@rvenditti,@syuvivida,@tjavaid,@nothingface0,@antoniovagnerini you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented May 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @makortel.

@Dr15Jones, @antoniovilela, @rappoccio, @sextonkennedy, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Jun 4, 2024

Could somebody look into this? The amount of logs is quite substantial.

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 5, 2024

type jetmet

@cmsbuild cmsbuild added the jetmet label Jun 5, 2024
@jfernan2
Copy link
Contributor

jfernan2 commented Jun 5, 2024

@iatakisi as current DQM Offline expert, could you please have a look?

@nurfikri89
Copy link
Contributor

@makortel @jfernan2 has this been resolved? I can take a look at this from the jetmet side.

@jfernan2
Copy link
Contributor

No, it has not, please have a llok and make a proposal for solution. Thanks

@nurfikri89
Copy link
Contributor

The printouts appear because one of the levels in the latest JECs is now dependent on jet phi. The variable is not explicitly set here:

if (ispat) {
jecCor_->setJetPt(patjet->correctedJet(0).pt());
} else {
jecCor_->setJetPt(jet.pt());
}
jecCor_->setJetEta(jet.eta());
jecCor_->setJetA(jet.jetArea());
jecCor_->setRho(rho);

Simply adding jecCor_->setJetPhi(jet.phi()); suppress the message. I have tested that the prinouts no longer appear using RunPromptReco.py. The PRs for the master and 14_0_X branches will be submitted shortly.

@jfernan2
Copy link
Contributor

Thanks @nurfikri89 !

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 2, 2024

+1
Fixed by #45270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants