-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update edm::bit_cast
[14.0.x]
#45200
Conversation
Use std::bit_cast in C++20 mode, or __builtin_bit_cast if available, otherwise fall back to memcpy.
backport #45166 |
please test |
A new Pull Request was created by @fwyzard for CMSSW_14_0_X. It involves the following packages:
@smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test RecoPPSLocalNewT2 had ERRORS Comparison SummarySummary:
|
ignore tests-rejected with ib-failure
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (test failures were overridden) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
PR description:
Update
edm::bit_cast
to usestd::bit_cast
in C++20 mode, otherwise fall back to__builtin_bit_cast
if available.PR validation:
None.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #45166 to 14.0.x for data taking, using the same branch.