Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update edm::bit_cast [14.0.x] #45200

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 11, 2024

PR description:

Update edm::bit_cast to use std::bit_cast in C++20 mode, otherwise fall back to __builtin_bit_cast if available.

PR validation:

None.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45166 to 14.0.x for data taking, using the same branch.

Use std::bit_cast in C++20 mode, or __builtin_bit_cast if available, otherwise
fall back to memcpy.
@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 11, 2024

backport #45166

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 11, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • FWCore/Utilities (core)

@smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@felicepantaleo, @missirol, @wddgit, @makortel this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6db41/39842/summary.html
COMMIT: c619df6
CMSSW: CMSSW_14_0_X_2024-06-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45200/39842/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoPPSLocalNewT2 had ERRORS

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338712
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338689
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 12, 2024 via email

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (test failures were overridden) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 14011de into cms-sw:CMSSW_14_0_X Jun 13, 2024
26 of 27 checks passed
@fwyzard fwyzard deleted the update_edm_bit_cast branch June 13, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants