Update edm::bit_cast

[fwyzard]

PR description:

Update edm::bit_cast to use std::bit_cast in C++20 mode, otherwise fall back to __builtin_bit_cast if available.

PR validation:

None.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14.0.x for data taking, using the same branch.

[cmsbuild]

cms-bot internal usage

[fwyzard]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45166/40512

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45166/40512/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45166/40512/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[fwyzard]

please test

[fwyzard]

@Dr15Jones does it look OK to you ?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45166/40513

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• FWCore/Utilities (core)

@Dr15Jones, @smuzaffar, @makortel can you please review it and eventually sign? Thanks.
@wddgit, @makortel, @felicepantaleo, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f9c33/39769/summary.html
COMMIT: 65cd151
CMSSW: CMSSW_14_1_X_2024-06-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45166/39769/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoPPSLocalNewT2 had ERRORS

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338974
• DQMHistoTests: Total failures: 854
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338100
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

@smuzaffar is there a way to test is PR under clang as well?

[cmsbuild]

Pull request #45166 was updated. @smuzaffar, @Dr15Jones, @cmsbuild, @makortel can you please check and sign again.

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45166/40535

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #45166 was updated. @Dr15Jones, @smuzaffar, @makortel can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f9c33/39805/summary.html
COMMIT: c619df6
CMSSW: CMSSW_14_1_X_2024-06-09-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45166/39805/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338974
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338954
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

please test for CMSSW_14_1_CLANG_X

Just to be sure. Wants it passes I'll sign.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f9c33/39829/summary.html
COMMIT: c619df6
CMSSW: CMSSW_14_1_CLANG_X_2024-06-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45166/39829/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 14209 lines to the logs
• Reco comparison results: 30367 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338974
• DQMHistoTests: Total failures: 38027
• DQMHistoTests: Total nulls: 153
• DQMHistoTests: Total successes: 3300774
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.02 KiB( 47 files compared)
• DQMHistoSizes: changed ( 140.043 ): -0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 140.063 ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.042 ): 0.023 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.044 ): -0.027 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 4 / 46 workflows

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1