Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPS] Run the T2 test with ROOT Raw instead of streamer files [backport of 45144] #45192

Merged

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented Jun 11, 2024

PR description:

This PR fixes issue #45101
The original streamer file used for test of T2 unpacker were replaced with ROOT RAW files.
The ROOT Raw files were generated using https://github.com/CTPPS/data2022test/blob/main/streamer-test.py script in rel CMSSW_14_1_0_pre3

PR validation:

I checked the unit test with local file, it runs as expected. This PR should run the test on top of cms-data/RecoPPS-Local#2 , as suggested in #45101 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45144

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @grzanka for CMSSW_14_0_X.

It involves the following packages:

  • RecoPPS/Local (reconstruction)

@jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @forthommel this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor

test parameters:

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24e5fc/39828/summary.html
COMMIT: 6846b1d
CMSSW: CMSSW_14_0_X_2024-06-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45192/39828/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 27 lines to the logs
  • Reco comparison results: 39 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338712
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338692
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Jun 14, 2024

@cms-sw/reconstruction-l2 can you please sign this to avoid IB test failures ?

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9240

@antoniovilela
Copy link
Contributor

cms-sw/cmsdist#9240 is merged.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7e7b449 into cms-sw:CMSSW_14_0_X Jun 17, 2024
11 checks passed
@forthommel forthommel deleted the CMSSW_14_0_X_fix_T2TOTEMtest_backport branch July 4, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants