-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PPS] Run the T2 test with ROOT Raw instead of streamer files [backport of 45144] #45192
[PPS] Run the T2 test with ROOT Raw instead of streamer files [backport of 45144] #45192
Conversation
A new Pull Request was created by @grzanka for CMSSW_14_0_X. It involves the following packages:
@jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
test parameters: |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24e5fc/39828/summary.html Comparison SummarySummary:
|
@cms-sw/reconstruction-l2 can you please sign this to avoid IB test failures ? |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
cms-sw/cmsdist#9240 is merged. |
+1 |
PR description:
This PR fixes issue #45101
The original streamer file used for test of T2 unpacker were replaced with ROOT RAW files.
The ROOT Raw files were generated using https://github.com/CTPPS/data2022test/blob/main/streamer-test.py script in rel CMSSW_14_1_0_pre3
PR validation:
I checked the unit test with local file, it runs as expected. This PR should run the test on top of cms-data/RecoPPS-Local#2 , as suggested in #45101 (comment)
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #45144