-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure in RecoPPSLocalNewT2 unit test #45101
Comments
cms-bot internal usage |
A new Issue was created by @makortel. @smuzaffar, @makortel, @rappoccio, @antoniovilela, @sextonkennedy, @Dr15Jones can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign RecoPPS/Local |
New categories assigned: reconstruction @jfernan2,@mandrenguyen you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@cms-sw/ctpps-dpg-l2 The test fails because the streamer format was changed. Does this test really need to read a streamer file, or could it read a root file? |
type ctpps |
Could someone look into this? (or should we look into disabling the test?) |
I've investigated the test a bit. It seems that we can convert the input streamer file into RAW ROOT format and run the problematic test on it. If everything goes well with the conversion I'll put converted file on CERNBOX and make the PR with fixes (once the file is available in the area where testing machinery can access it). |
@makortel I've put the converted RAW file here: https://cernbox.cern.ch/s/OD136wlNpQfH4X8 , would it be possible to upload it somewhere where the Jenkins can access it ? |
Thanks @grzanka! To me it would make sense to place the new file where the present file is, whose location is defined in https://github.com/cms-data/RecoPPS-Local , but I don't know how to get the file in http://cmsrep.cern.ch/cmssw/download . @smuzaffar could you help? |
@grzanka , if the new file is less than 50MB then I would suggest to open a PR and add it to https://github.com/cms-data/RecoPPS-Local . If it ia over 50MB then please copy it to your afs public directory |
The file is ~77MB, I've copied it to |
thanks @grzanka , so do we need to keep both
files in RecoPPS/Local or just the new one is enough? By the way, we should not use |
For the moment we would prefer to keep both files. Thank you for the hints with the paths, I will now prepare a PR with fix |
How to use
|
You indeed can't. However, there is a utility that resolves the search in python and returns
cmssw/FWCore/Modules/test/testBunchCrossingFilter.py Lines 42 to 44 in a9682e8
for an example |
cms-data/RecoPPS-Local#2 is now open, cmssw PR should use this for testing |
If the old file would be removed, the unit test would start to fail in old release cycles. Which reminds me, the fix in the unit test needs to be backported to 14_0_X too (or merging #44978 will cause the test to fail there) |
I meant, do we need to drop the old file from data-RecoPPS-Local package? i.e. it will not be removed from the cmsrep.cern.ch download area but from the package we distribute on cvmfs. Old releases will keep one accessing it from cmsrep |
Ah, then I'd be fine with removing the old file from data-RecoPPS-Local package. Do I understand correctly the benefit would be that the new releases would no longer distribute the old file (that would be unnecessary there). |
yes, new tag/version of data-RecoPPS-Local external will only have one file ( |
I've made the PR with necessary fixes: #45144
I suspect that would require a new release or the PR being merged. |
Jenkins tests are running for #45144 . In order to test it locally you can just copy |
Thanks, it worked ! |
It seems the tests on #45144 succeeded, what would be the next step ? |
It will be reviewed by corresponding L1 (reconstruction in this case), then by ORPs, which will then merge it. |
Will we need the backport to 14_0_X? |
As requested I've made a backport #45192 |
+1 |
This issue is fully signed and ready to be closed. |
The unit test
RecoPPSLocalNewT2
fails in CMSSW_14_1_X_2024-05-30-1100 ashttps://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_14_1_X_2024-05-30-1100/unitTestLogs/RecoPPS/Local#/
(noted also in #44892 (comment))
The failure is a consequence of the merge of #44892, but in this case it is the test that needs an update.
The text was updated successfully, but these errors were encountered: